Skip to content

Commit d3fb3bd

Browse files
committed
Add TODOs and comments
1 parent 7795ded commit d3fb3bd

File tree

4 files changed

+15
-0
lines changed

4 files changed

+15
-0
lines changed

tf2/include/tf2/impl/convert.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ struct DefaultMessageForDatatype
9090
alwaysFalse<Datatype>,
9191
"No default message type defined, "
9292
"please check your header file includes!");
93+
94+
// implement the following in the specializations for your own types
9395
// using type = ...;
9496
};
9597

@@ -115,6 +117,8 @@ struct DefaultTransformType
115117
alwaysFalse<Datatype>,
116118
"No default transform type defined, "
117119
"please check your header file includes!");
120+
121+
// implement the following in the specializations for your own types
118122
// using type = ...;
119123
};
120124

@@ -146,6 +150,8 @@ struct ConversionImplementation
146150
alwaysFalse<Datatype>,
147151
"No Conversion Implementation available, "
148152
"please check your header file includes!");
153+
154+
// implement the following in the specializations for your own types
149155
// void toMsg(const Datatype&, Message&);
150156
// void fromMsg(const Message&, Datatype&);
151157
};
@@ -190,6 +196,8 @@ struct StampedMessageTraits
190196
alwaysFalse<StampedMessage>,
191197
"No traits for this stamped message type available, "
192198
"please check your header file includes!");
199+
200+
// implement the following in the specializations for your own types
193201
// using UntampedType = ...;
194202
// static UntampedType& accessMessage(StampedMsg &);
195203
// static UntampedType getMessage(StampedMsg const&);
@@ -226,6 +234,8 @@ struct UnstampedMessageTraits
226234
alwaysFalse<UnstampedMessage>,
227235
"No traits for this message type available, "
228236
"please check your header file includes!");
237+
238+
// implement the following in the specializations for your own types
229239
// using StampedType = ...;
230240
// using StampedTypeWithCovariance = ...;
231241
};

tf2_geometry_msgs/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ if(BUILD_TESTING)
3131
find_package(ament_cmake_gtest REQUIRED)
3232
find_package(rclcpp REQUIRED)
3333

34+
# TODO(ros2/geometry2#259) Switch to ament_lint_auto once headers
35+
# are renamed to .hpp
3436
find_package(ament_cmake_cppcheck REQUIRED)
3537
find_package(ament_cmake_cpplint REQUIRED)
3638
find_package(ament_cmake_lint_cmake REQUIRED)

tf2_kdl/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ if(BUILD_TESTING)
3434
find_package(rclcpp REQUIRED)
3535
find_package(tf2_msgs REQUIRED)
3636

37+
# TODO(ros2/geometry2#259) Switch to ament_lint_auto once headers
38+
# are renamed to .hpp
3739
find_package(ament_cmake_cppcheck REQUIRED)
3840
find_package(ament_cmake_cpplint REQUIRED)
3941
find_package(ament_cmake_lint_cmake REQUIRED)

tf2_sensor_msgs/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ if(BUILD_TESTING)
3030
find_package(ament_cmake_gtest REQUIRED)
3131
find_package(ament_cmake_pytest REQUIRED)
3232

33+
# TODO(ros2/orocos_kinematics_dynamics): reenable when PyKDL is ready to use
3334
#ament_add_pytest_test(test_tf2_sensor_msgs_py test/test_tf2_sensor_msgs.py)
3435

3536
ament_add_gtest(test_tf2_sensor_msgs_cpp test/test_tf2_sensor_msgs.cpp)

0 commit comments

Comments
 (0)