Skip to content

Commit 56f4334

Browse files
committed
Delete outdated comments
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
1 parent c3f9697 commit 56f4334

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

launch_testing/test/launch_testing/new_hooks/test_function_scope.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@ def launch_description():
3131
])
3232

3333

34-
# TODO(ivanpauno)
35-
# We cannot get variables from the dictionary returned by launch_description
36-
# because we're removing the fixture before running the tests.
37-
# Maybe we can delete this feature, and use generators/asyncgens.
38-
# We can always get the variables returned by the launch_testing fixture there.
3934
@pytest.mark.launch_testing(fixture=launch_description, shutdown=True)
4035
async def test_after_shutdown(order, launch_service):
4136
order.append('test_after_shutdown')

launch_testing/test/launch_testing/new_hooks/test_module_scope.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ def launch_description(request):
3333
]), request.param
3434

3535

36-
# TODO(ivanpauno)
37-
# We cannot get variables from the dictionary returned by launch_description
38-
# because we're removing the fixture before running the tests.
39-
# Maybe we can delete this feature, and use generators/asyncgens.
4036
@pytest.mark.launch_testing(fixture=launch_description, shutdown=True)
4137
def test_after_shutdown(order, launch_service, launch_description):
4238
param = launch_description[1]

0 commit comments

Comments
 (0)