Renamed three files from example_processes (#573)

* Renamed three files from example_processes
Three python files did not have a '.py' extension. These are always used as python scripts and it makes sense for them to have a python extension.

Signed-off-by: Khush-dev <[email protected]>

* Edited all references to the files that were renamed in previous commit
Modified renamed files to follow code style adopted for python scripts

Signed-off-by: Khush-dev <[email protected]>

Author: Khush-dev

launch_testing/README.md

@@ -224,8 +224,8 @@ Usage:
 launch_test test/launch_testing/examples/good_proc_launch_test.py
 ```
 
-This test checks a process called good_proc (source found in the [example_processes folder](example_processes)).
-good_proc is a simple python process that prints "Loop 1, Loop2, etc. every second until it's terminated with ctrl+c.
+This test checks a process called good_proc.py (source found in the [example_processes folder](example_processes)).
+good_proc.py is a simple python process that prints "Loop 1, Loop2, etc. every second until it's terminated with ctrl+c.
 The test will launch the process, wait for a few loops to complete by monitoring stdout, then terminate the process
 and run some post-shutdown checks.
 

launch_testing/example_processes/exit_code_proc renamed to launch_testing/example_processes/exit_code_proc.py

@@ -15,18 +15,17 @@
 # limitations under the License.
 
 import sys
-import time
 
 
 # This process pretends to do some simple setup, then pretends to do some simple work,
 # then shuts itself down automatically
-if __name__ == "__main__":
+if __name__ == '__main__':
 
-    if "--silent" in sys.argv[1:]:
+    if '--silent' in sys.argv[1:]:
         sys.exit(1)
 
     if '--exception' in sys.argv[1:]:
-        raise Exception("Process had a pretend error")
+        raise Exception('Process had a pretend error')
 
-    print("Exiting with a code")
-    sys.exit(1) 
+    print('Exiting with a code')
+    sys.exit(1)

launch_testing/example_processes/good_proc renamed to launch_testing/example_processes/good_proc.py

@@ -20,22 +20,22 @@
 
 # This is a simple program that generates some stdout, waits for ctrl+c, and exits with
 # an exit code of zero
-if __name__ == "__main__":
+if __name__ == '__main__':
 
     if sys.argv[1:]:
-        print("Called with arguments {}".format(sys.argv[1:]))
+        print('Called with arguments {}'.format(sys.argv[1:]))
 
-    print("Starting Up")
+    print('Starting Up')
 
     loops = 0
     try:
         while True:
-            print("Loop {}".format(loops))
+            print('Loop {}'.format(loops))
             loops += 1
             time.sleep(1.0)
     except KeyboardInterrupt:
         pass
 
-    print("Shutting Down")
+    print('Shutting Down')
 
     sys.exit(0)

launch_testing/example_processes/terminating_proc renamed to launch_testing/example_processes/terminating_proc.py

@@ -20,25 +20,25 @@
 
 # This process pretends to do some simple setup, then pretends to do some simple work,
 # then shuts itself down automatically
-if __name__ == "__main__":
+if __name__ == '__main__':
 
-    print("Starting Up")
+    print('Starting Up')
     time.sleep(1.0)
-    print("Ready")
+    print('Ready')
 
     if sys.argv[1:]:
-        print("Called with arguments {}".format(sys.argv[1:]))
+        print('Called with arguments {}'.format(sys.argv[1:]))
 
     if '--exception' in sys.argv[1:]:
-        raise Exception("Process had a pretend error")
+        raise Exception('Process had a pretend error')
 
     try:
-        print("Emulating Work")
+        print('Emulating Work')
         time.sleep(1.0)
-        print("Done")
+        print('Done')
     except KeyboardInterrupt:
         pass
 
-    print("Shutting Down")
+    print('Shutting Down')
 
     sys.exit(0)

launch_testing/test/launch_testing/examples/args_launch_test.py

@@ -37,7 +37,7 @@ def generate_test_description():
             os.path.join(
                 ament_index_python.get_package_prefix('launch_testing'),
                 'lib/launch_testing',
-                'terminating_proc',
+                'terminating_proc.py',
             ),
 
             # Arguments

launch_testing/test/launch_testing/examples/context_launch_test.py

@@ -32,11 +32,11 @@ def get_test_process_action():
     TEST_PROC_PATH = os.path.join(
         ament_index_python.get_package_prefix('launch_testing'),
         'lib/launch_testing',
-        'good_proc'
+        'good_proc.py'
     )
     return launch.actions.ExecuteProcess(
         cmd=[sys.executable, TEST_PROC_PATH],
-        name='good_proc',
+        name='good_proc.py',
         # This is necessary to get unbuffered output from the process under test
         additional_env={'PYTHONUNBUFFERED': '1'},
     )
@@ -96,9 +96,9 @@ def test_int_val(self, int_val):
     def test_all_context_objects(self, int_val, dut):
         # Multiple arguments are supported
         self.assertEqual(int_val, 10)
-        self.assertIn('good_proc', dut.process_details['name'])
+        self.assertIn('good_proc.py', dut.process_details['name'])
 
     def test_all_context_objects_different_order(self, dut, int_val):
         # Put the arguments in a different order from the above test
         self.assertEqual(int_val, 10)
-        self.assertIn('good_proc', dut.process_details['name'])
+        self.assertIn('good_proc.py', dut.process_details['name'])

launch_testing/test/launch_testing/examples/good_proc_launch_test.py

@@ -33,7 +33,7 @@ def generate_test_description():
     TEST_PROC_PATH = os.path.join(
         ament_index_python.get_package_prefix('launch_testing'),
         'lib/launch_testing',
-        'good_proc'
+        'good_proc.py'
     )
 
     # This is necessary to get unbuffered output from the process under test

launch_testing/test/launch_testing/examples/parameters_launch_test.py

@@ -37,7 +37,7 @@ def generate_test_description(arg_param):
             os.path.join(
                 ament_index_python.get_package_prefix('launch_testing'),
                 'lib/launch_testing',
-                'terminating_proc',
+                'terminating_proc.py',
             ),
             # Use the parameter passed to generate_test_description as an argument
             # to the terminating_proc

launch_testing/test/launch_testing/examples/ready_action_test.py

@@ -33,7 +33,7 @@ def generate_test_description():
     TEST_PROC_PATH = os.path.join(
         ament_index_python.get_package_prefix('launch_testing'),
         'lib/launch_testing',
-        'good_proc'
+        'good_proc.py'
     )
 
     # This is necessary to get unbuffered output from the process under test

launch_testing/test/launch_testing/examples/terminating_proc_launch_test.py

@@ -34,11 +34,11 @@ def get_test_process_action(*, args=[]):
     test_proc_path = os.path.join(
         ament_index_python.get_package_prefix('launch_testing'),
         'lib/launch_testing',
-        'terminating_proc'
+        'terminating_proc.py'
     )
     return launch.actions.ExecuteProcess(
         cmd=[sys.executable, test_proc_path, *args],
-        name='terminating_proc',
+        name='terminating_proc.py',
         # This is necessary to get unbuffered output from the process under test
         additional_env={'PYTHONUNBUFFERED': '1'},
         output='screen'