add yaml and xml tests for split_arguments

Signed-off-by: William Woodall <[email protected]>

Author: wjwwood

launch_xml/test/launch_xml/arg_echo.py

@@ -0,0 +1,28 @@
+# Copyright 2023 Open Source Robotics Foundation, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Used from test_executable.py and others."""
+
+
+import sys
+
+
+def print_argv(argv):
+    joined_args = "', '".join(argv)
+    print(f"['{joined_args}']")
+    sys.exit(len(argv))
+
+
+if __name__ == '__main__':
+    print_argv(sys.argv)

launch_xml/test/launch_xml/test_executable.py

@@ -15,6 +15,7 @@
 """Test parsing an executable action."""
 
 import io
+import os
 from pathlib import Path
 import sys
 import textwrap
@@ -67,25 +68,28 @@ def test_executable_wrong_subtag():
     assert '`executable`' in str(excinfo.value)
     assert 'whats_this' in str(excinfo.value)
 
-    # <let name="script" value="print('hello world')" />
-split_arguments_example = f"""
+
+split_arguments_example1 = f"""
 <launch>
-    <executable cmd="{sys.executable} -c 'print(0)'" log_cmd="True" split_arguments="True" />
+    <let name="args" value="--some-arg 'some string'" />
+    <executable
+        cmd="{sys.executable} {os.path.join(os.path.dirname(__file__), 'arg_echo.py')} $(var args)"
+        log_cmd="True"
+        split_arguments="True"
+        output="screen"
+    />
 </launch>
 """
 
 
 def test_executable_with_split_arguments():
     """Parse node xml example."""
-    root_entity, parser = Parser.load(io.StringIO(split_arguments_example))
+    root_entity, parser = Parser.load(io.StringIO(split_arguments_example1))
     ld = parser.parse_description(root_entity)
     ls = LaunchService()
     ls.include_launch_description(ld)
     assert 0 == ls.run()
 
-    executable = ld.entities[0]
-    assert False, executable.get_stdout()
-
-
-if __name__ == '__main__':
-    test_executable()
+    executable = ld.entities[-1]
+    # expect a return code that matches the number of arguments after the executable
+    assert executable.return_code == 3

launch_yaml/test/launch_yaml/arg_echo.py

@@ -0,0 +1,28 @@
+# Copyright 2023 Open Source Robotics Foundation, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Used from test_executable.py and others."""
+
+
+import sys
+
+
+def print_argv(argv):
+    joined_args = "', '".join(argv)
+    print(f"['{joined_args}']")
+    sys.exit(len(argv))
+
+
+if __name__ == '__main__':
+    print_argv(sys.argv)

launch_yaml/test/launch_yaml/test_executable.py

@@ -15,6 +15,8 @@
 """Test parsing an executable action."""
 
 import io
+import os
+import sys
 import textwrap
 
 from launch import LaunchService
@@ -64,5 +66,28 @@ def test_executable():
     assert(0 == ls.run())
 
 
-if __name__ == '__main__':
-    test_executable()
+split_arguments_example1 = f"""
+launch:
+- let:
+    name: args
+    value: '--some-arg "some string"'
+- executable:
+        cmd: {sys.executable} {os.path.join(os.path.dirname(__file__), 'arg_echo.py')} $(var args)
+        log_cmd: True
+        shell: False
+        split_arguments: True
+        output: screen
+"""
+
+
+def test_executable_with_split_arguments():
+    """Parse node xml example."""
+    root_entity, parser = Parser.load(io.StringIO(split_arguments_example1))
+    ld = parser.parse_description(root_entity)
+    ls = LaunchService()
+    ls.include_launch_description(ld)
+    assert 0 == ls.run()
+
+    executable = ld.entities[-1]
+    # expect a return code that matches the number of arguments after the executable
+    assert executable.return_code == 3