Skip to content

Commit 1bc6601

Browse files
ijnekmergify[bot]
authored andcommitted
improve type readability in errors (#469)
Signed-off-by: ijnek <[email protected]> (cherry picked from commit 9c5f6a7) # Conflicts: # launch_ros/launch_ros/utilities/evaluate_parameters.py
1 parent a6c8293 commit 1bc6601

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

launch_ros/launch_ros/parameter_descriptions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def value_type(self) -> AllowedTypesType:
8383
def __str__(self) -> Text:
8484
return (
8585
'launch_ros.description.ParameterValue'
86-
f'(value={self.value}, value_type={self.value_type})'
86+
f'(value={self.value}, value_type={self.value_type.__name__})'
8787
)
8888

8989
def evaluate(self, context: LaunchContext) -> 'EvaluatedParameterValue':
@@ -148,7 +148,7 @@ def value_type(self) -> AllowedTypesType:
148148
def __str__(self) -> Text:
149149
return (
150150
'launch_ros.description.Parameter'
151-
f'(name={self.name}, value={self.value}, value_type={self.value_type})'
151+
f'(name={self.name}, value={self.value}, value_type={self.value_type.__name__})'
152152
)
153153

154154
def evaluate(self, context: LaunchContext) -> Tuple[Text, 'EvaluatedParameterValue']:

launch_ros/launch_ros/utilities/evaluate_parameters.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,14 @@ def check_sequence_type_is_allowed(sequence):
102102
', Sequence[int], Sequence[float], Sequence[str]. Got {}.'
103103
'If the parameter is meant to be a string, try wrapping it in '
104104
'launch_ros.parameter_descriptions.ParameterValue'
105+
<<<<<<< HEAD
105106
'(value, value_type=str)'.format(type(yaml_evaluated_value))
107+
=======
108+
'(value, value_type=str)'.format(
109+
type(yaml_evaluated_value).__name__,
110+
evaluated_name
111+
)
112+
>>>>>>> 9c5f6a7 (improve type readability in errors (#469))
106113
)
107114
elif isinstance(value[0], Sequence):
108115
# Value is an array of a list of substitutions

0 commit comments

Comments
 (0)