Skip to content

Commit 1f0ea9f

Browse files
authored
Drop double single-quoted params. (#164)
Invalid if type coerced using YAML rules. Signed-off-by: Michel Hidalgo <[email protected]>
1 parent 70c9a8d commit 1f0ea9f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

test_launch_ros/test/test_launch_ros/frontend/test_node_frontend.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,11 @@ def test_launch_remapping_xml():
4747
<param name="param5" value="$(var a_string)"/>
4848
<param name="param6" value="2., 5., 8." value-sep=", "/>
4949
<param name="param7" value="'2', '5', '8'" value-sep=", "/>
50-
<param name="param8" value="''2'', ''5'', ''8''" value-sep=", "/>
50+
<!-- TODO(hidmic): revisit after https://github.com/ros2/launch_ros/pull/137 gets merged -->
51+
<param name="param8" value="&quot;'2'&quot;, &quot;'5'&quot;, &quot;'8'&quot;" value-sep=", "/>
5152
<param name="param9" value="\'2\', \'5\', \'8\'" value-sep=", "/>
52-
<param name="param10" value="''asd'', ''bsd'', ''csd''" value-sep=", "/>
53+
<!-- TODO(hidmic): revisit after https://github.com/ros2/launch_ros/pull/137 gets merged -->
54+
<param name="param10" value="&quot;'asd'&quot;, &quot;'bsd'&quot;, &quot;'csd'&quot;" value-sep=", "/>
5355
<param name="param11" value="'\asd', '\bsd', '\csd'" value-sep=", "/>
5456
<param name="param12" value=""/>
5557
</param>

0 commit comments

Comments
 (0)