Validate complex attributes of 'node' action (#198)

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Author: ivanpauno

launch_ros/launch_ros/actions/node.py

@@ -192,6 +192,7 @@ def get_nested_dictionary_from_nested_key_value_pairs(params):
                     data_type = get_data_type_from_identifier(type_identifier)
                 value = param.get_attr('value', data_type=data_type, optional=True)
                 nested_params = param.get_attr('param', data_type=List[Entity], optional=True)
+                param.assert_entity_completely_parsed()
                 if value is not None and nested_params:
                     raise RuntimeError(
                         'nested parameters and value attributes are mutually exclusive')
@@ -224,6 +225,7 @@ def get_nested_dictionary_from_nested_key_value_pairs(params):
                     allow_substs = parser.parse_substitution(allow_substs)
                 else:
                     allow_substs = bool(allow_substs)
+                param.assert_entity_completely_parsed()
                 normalized_params.append(
                     ParameterFile(parser.parse_substitution(from_attr), allow_substs=allow_substs))
                 continue
@@ -269,6 +271,8 @@ def parse(cls, entity: Entity, parser: Parser):
                     parser.parse_substitution(remap.get_attr('to'))
                 ) for remap in remappings
             ]
+            for remap in remappings:
+                remap.assert_entity_completely_parsed()
         parameters = entity.get_attr('param', data_type=List[Entity], optional=True)
         if parameters is not None:
             kwargs['parameters'] = cls.parse_nested_parameters(parameters, parser)