Skip to content

Commit 3cd7515

Browse files
authored
Re-order shutdown vs node destruction (#213)
I'm not sure if calling Node.destroy_node() while another thread is spinning was ever supported, but it definitely causes problems. Signed-off-by: Scott K Logan <[email protected]>
1 parent 2f09c64 commit 3cd7515

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test_launch_ros/test/test_launch_ros/actions/test_load_composable_nodes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ def load_node_callback(self, request, response):
7676

7777
def shutdown(self):
7878
self._executor.shutdown()
79-
self.destroy_node()
8079
rclpy.shutdown(context=self._context)
80+
self.destroy_node()
8181
self._thread.join()
8282

8383

0 commit comments

Comments
 (0)