Skip to content

Commit 82fe7c5

Browse files
authored
add "--log-file-name" command line argument for test. (#387)
Signed-off-by: Tomoya Fujita <[email protected]>
1 parent edaf38f commit 82fe7c5

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

test_launch_ros/test/test_launch_ros/actions/test_node.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,12 @@ def test_launch_node_with_remappings(self):
9494
assert expanded_remappings[i] == ('chatter', 'new_chatter')
9595

9696
def test_launch_node_with_ros_arguments(self):
97-
node_action = self._create_node(ros_arguments=['--log-level', 'debug'])
97+
node_action = self._create_node(
98+
ros_arguments=['--log-level', 'debug', '--log-file-name', 'filename'])
9899
self._assert_launch_no_errors([node_action])
99100

100101
cmd_string = ' '.join(node_action.process_details['cmd'])
101-
assert '--ros-args --log-level debug' in cmd_string
102+
assert '--ros-args --log-level debug --log-file-name filename' in cmd_string
102103

103104
def test_launch_required_node(self):
104105
# This node will never exit on its own, it'll keep publishing forever.

test_launch_ros/test/test_launch_ros/frontend/test_node_frontend.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def test_launch_frontend_xml():
3737
<let name="a_string" value="\'[2, 5, 8]\'"/>
3838
<let name="a_list" value="[2, 5, 8]"/>
3939
<let name="my_value" value="100"/>
40-
<node pkg="demo_nodes_py" exec="talker_qos" output="screen" name="my_talker" namespace="my_ns" exec_name="my_talker_process" args="--number_of_cycles 1" ros_args="--log-level info">
40+
<node pkg="demo_nodes_py" exec="talker_qos" output="screen" name="my_talker" namespace="my_ns" exec_name="my_talker_process" args="--number_of_cycles 1" ros_args="--log-level info --log-file-name filename">
4141
<param name="param1" value="ads"/>
4242
<param name="param_group1">
4343
<param name="param_group2">
@@ -91,7 +91,7 @@ def test_launch_frontend_yaml():
9191
namespace: my_ns
9292
exec_name: my_talker_process
9393
args: '--number_of_cycles 1'
94-
ros_args: '--log-level info'
94+
ros_args: '--log-level info --log-file-name filename'
9595
param:
9696
- name: param1
9797
value: ads
@@ -206,7 +206,7 @@ def check_launch_node(file):
206206

207207
talker_node_action = ld.describe_sub_entities()[3]
208208
talker_node_cmd_string = ' '.join(talker_node_action.process_details['cmd'])
209-
assert '--ros-args --log-level info' in talker_node_cmd_string
209+
assert '--ros-args --log-level info --log-file-name filename' in talker_node_cmd_string
210210

211211
listener_node_action = ld.describe_sub_entities()[4]
212212
listener_node_cmd = listener_node_action.process_details['cmd']

0 commit comments

Comments
 (0)