Skip to content

Commit 98952b5

Browse files
Fixing lifecycle node autostart issue #445 (#449)
Signed-off-by: Steve Macenski <[email protected]>
1 parent 9abb3be commit 98952b5

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

launch_ros/launch_ros/actions/lifecycle_node.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,8 @@ def execute(self, context: launch.LaunchContext) -> Optional[List[Action]]:
107107
autostart_actions = [
108108
LifecycleTransition(
109109
lifecycle_node_names=[self.node_name],
110-
transition_ids=[lifecycle_msgs.msg.Transition.TRANSITION_CONFIGURE]
111-
),
112-
LifecycleTransition(
113-
lifecycle_node_names=[self.node_name],
114-
transition_ids=[lifecycle_msgs.msg.Transition.TRANSITION_ACTIVATE]
110+
transition_ids=[lifecycle_msgs.msg.Transition.TRANSITION_CONFIGURE,
111+
lifecycle_msgs.msg.Transition.TRANSITION_ACTIVATE]
115112
),
116113
]
117114

launch_ros/launch_ros/actions/load_composable_nodes.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -251,14 +251,9 @@ def execute(
251251
autostart_actions.append(
252252
LifecycleTransition(
253253
lifecycle_node_names=[complete_node_name],
254-
transition_ids=[lifecycle_msgs.msg.Transition.TRANSITION_CONFIGURE]
254+
transition_ids=[lifecycle_msgs.msg.Transition.TRANSITION_CONFIGURE,
255+
lifecycle_msgs.msg.Transition.TRANSITION_ACTIVATE]
255256
))
256-
autostart_actions.append(
257-
LifecycleTransition(
258-
lifecycle_node_names=[complete_node_name],
259-
transition_ids=[lifecycle_msgs.msg.Transition.TRANSITION_ACTIVATE]
260-
),
261-
)
262257

263258
if load_node_requests:
264259
context.add_completion_future(

0 commit comments

Comments
 (0)