Make rmw_destroy_wait_set return RMW_RET_INVALID_ARGUMENT (#766)

christophebedard-apexai · web-flow · commit 0ddf087ce688 · 2024-06-13T15:12:45.000-04:00
Signed-off-by: Christophe Bedard &lt;christophe.bedard@apex.ai&gt;
diff --git a/rmw_fastrtps_shared_cpp/src/rmw_wait_set.cpp b/rmw_fastrtps_shared_cpp/src/rmw_wait_set.cpp
@@ -76,7 +76,7 @@ __rmw_create_wait_set(const char * identifier, rmw_context_t * context, size_t m
 rmw_ret_t
 __rmw_destroy_wait_set(const char * identifier, rmw_wait_set_t * wait_set)
 {
-  RMW_CHECK_ARGUMENT_FOR_NULL(wait_set, RMW_RET_ERROR);
+  RMW_CHECK_ARGUMENT_FOR_NULL(wait_set, RMW_RET_INVALID_ARGUMENT);
   RMW_CHECK_TYPE_IDENTIFIERS_MATCH(
     wait set handle,
     wait_set->implementation_identifier, identifier,

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ __rmw_create_wait_set(const char * identifier, rmw_context_t * context, size_t m`
`76`	`76`	`rmw_ret_t`
`77`	`77`	`__rmw_destroy_wait_set(const char * identifier, rmw_wait_set_t * wait_set)`
`78`	`78`	`{`
`79`		`- RMW_CHECK_ARGUMENT_FOR_NULL(wait_set, RMW_RET_ERROR);`
	`79`	`+ RMW_CHECK_ARGUMENT_FOR_NULL(wait_set, RMW_RET_INVALID_ARGUMENT);`
`80`	`80`	`RMW_CHECK_TYPE_IDENTIFIERS_MATCH(`
`81`	`81`	`wait set handle,`
`82`	`82`	`wait_set->implementation_identifier, identifier,`