Return specific error when not finding a node name (#281)

ivanpauno · web-flow · commit 152c75166888 · 2019-09-17T10:26:29.000-03:00
Signed-off-by: ivanpauno &lt;ivanpauno@ekumenlabs.com&gt;
diff --git a/rmw_opensplice_cpp/src/rmw_node_info_and_types.cpp b/rmw_opensplice_cpp/src/rmw_node_info_and_types.cpp
@@ -162,8 +162,12 @@ __get_key(
     return RMW_RET_OK;
   }
 
-  RMW_SET_ERROR_MSG("unable to match node_name/namespace with discovered nodes.");
-  return RMW_RET_ERROR;
+  RMW_SET_ERROR_MSG_WITH_FORMAT_STRING(
+    "Node name not found: ns='%s', name='%s",
+    node_namespace,
+    node_name
+  );
+  return RMW_RET_NODE_NAME_NON_EXISTENT;
 }
 
 rmw_ret_t

Original file line number	Diff line number	Diff line change
`@@ -162,8 +162,12 @@ __get_key(`
`162`	`162`	`return RMW_RET_OK;`
`163`	`163`	`}`
`164`	`164`
`165`		`- RMW_SET_ERROR_MSG("unable to match node_name/namespace with discovered nodes.");`
`166`		`- return RMW_RET_ERROR;`
	`165`	`+ RMW_SET_ERROR_MSG_WITH_FORMAT_STRING(`
	`166`	`+ "Node name not found: ns='%s', name='%s",`
	`167`	`+ node_namespace,`
	`168`	`+ node_name`
	`169`	`+ );`
	`170`	`+ return RMW_RET_NODE_NAME_NON_EXISTENT;`
`167`	`171`	`}`
`168`	`172`
`169`	`173`	`rmw_ret_t`