Revert "Skip CLI tests on Windows until we resolve the blocking/hanging isuse. (#489)"

This reverts commit 8ad1208.

Signed-off-by: Michel Hidalgo <[email protected]>

Author: hidmic

ros2action/test/test_cli.py

@@ -35,14 +35,6 @@
 import yaml
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 @pytest.mark.rostest
 @launch_testing.parametrize('rmw_implementation', get_available_rmw_implementations())
 def generate_test_description(rmw_implementation):

ros2interface/test/test_cli.py

@@ -15,7 +15,6 @@
 import contextlib
 import itertools
 import re
-import sys
 import unittest
 
 from launch import LaunchDescription
@@ -30,14 +29,6 @@
 import pytest
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 some_messages_from_test_msgs = [
     'test_msgs/msg/BasicTypes',
     'test_msgs/msg/Constants',

ros2lifecycle/test/test_cli.py

@@ -13,7 +13,6 @@
 # limitations under the License.
 
 import contextlib
-import sys
 import unittest
 
 from launch import LaunchDescription
@@ -32,14 +31,6 @@
 from rclpy.utilities import get_available_rmw_implementations
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 ALL_LIFECYCLE_NODE_TRANSITIONS = [
     '- configure [1]',
     '\tStart: unconfigured',

ros2node/test/test_cli.py

@@ -36,14 +36,6 @@
 from rclpy.utilities import get_available_rmw_implementations
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 @pytest.mark.rostest
 @launch_testing.parametrize('rmw_implementation', get_available_rmw_implementations())
 def generate_test_description(rmw_implementation):

ros2node/test/test_cli_duplicate_node_names.py

@@ -35,14 +35,6 @@
 from ros2node.api import INFO_NONUNIQUE_WARNING_TEMPLATE
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 @pytest.mark.rostest
 @launch_testing.parametrize('rmw_implementation', get_available_rmw_implementations())
 def generate_test_description(rmw_implementation):

ros2pkg/test/test_cli.py

@@ -14,7 +14,6 @@
 
 import contextlib
 import os
-import sys
 import tempfile
 import unittest
 import xml.etree.ElementTree as ET
@@ -31,14 +30,6 @@
 import pytest
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 some_cli_packages = [
     'ros2cli',
     'ros2pkg'

ros2service/test/test_cli.py

@@ -38,14 +38,6 @@
 from test_msgs.srv import BasicTypes
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 def get_echo_call_output(**kwargs):
     request = BasicTypes.Request()
     for field_name, field_value in kwargs.items():

ros2topic/test/test_cli.py

@@ -37,14 +37,6 @@
 from rclpy.utilities import get_available_rmw_implementations
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 @pytest.mark.rostest
 @launch_testing.parametrize('rmw_implementation', get_available_rmw_implementations())
 def generate_test_description(rmw_implementation):

ros2topic/test/test_echo_pub.py

@@ -13,7 +13,6 @@
 # limitations under the License.
 
 import functools
-import sys
 import unittest
 
 from launch import LaunchDescription
@@ -38,14 +37,6 @@
 from std_msgs.msg import String
 
 
-# Skip cli tests on Windows while they exhibit pathological behavior
-# https://github.com/ros2/build_farmer/issues/248
-if sys.platform.startswith('win'):
-    pytest.skip(
-            'CLI tests can block for a pathological amount of time on Windows.',
-            allow_module_level=True)
-
-
 TEST_NODE = 'cli_echo_pub_test_node'
 TEST_NAMESPACE = 'cli_echo_pub'