Skip to content

Commit 62db738

Browse files
authored
Make all of the dependencies in pure Python packages exec_depend. (#823)
That is, they have no build step, so they shouldn't export a dependency for that. Signed-off-by: Chris Lalancette <[email protected]>
1 parent 345693d commit 62db738

File tree

11 files changed

+17
-27
lines changed

11 files changed

+17
-27
lines changed

ros2action/package.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
<author email="[email protected]">Mabel Zhang</author>
1818
<author email="[email protected]">Michael Jeronimo</author>
1919

20-
<depend>rclpy</depend>
21-
<depend>ros2cli</depend>
22-
2320
<exec_depend>action_msgs</exec_depend>
2421
<exec_depend>ament_index_python</exec_depend>
22+
<exec_depend>rclpy</exec_depend>
23+
<exec_depend>ros2cli</exec_depend>
2524
<exec_depend>rosidl_runtime_py</exec_depend>
2625

2726
<test_depend>ament_copyright</test_depend>

ros2doctor/package.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,13 @@
1515
<author email="[email protected]">Mabel Zhang</author>
1616
<author email="[email protected]">Michael Jeronimo</author>
1717

18-
<depend>ros2cli</depend>
19-
2018
<exec_depend>ament_index_python</exec_depend>
2119
<exec_depend>python3-catkin-pkg-modules</exec_depend>
2220
<exec_depend>python3-psutil</exec_depend>
2321
<exec_depend>python3-importlib-metadata</exec_depend>
2422
<exec_depend>python3-rosdistro-modules</exec_depend>
2523
<exec_depend>rclpy</exec_depend>
24+
<exec_depend>ros2cli</exec_depend>
2625
<exec_depend>ros_environment</exec_depend>
2726
<exec_depend>std_msgs</exec_depend>
2827

ros2interface/package.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@
1818
<author email="[email protected]">Michael Jeronimo</author>
1919
<author>Siddharth Kucheria</author>
2020

21-
<depend>ros2cli</depend>
22-
2321
<exec_depend>ament_index_python</exec_depend>
22+
<exec_depend>ros2cli</exec_depend>
2423
<exec_depend>rosidl_adapter</exec_depend>
2524
<exec_depend>rosidl_runtime_py</exec_depend>
2625

ros2lifecycle/package.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@
1717
<author email="[email protected]">Mabel Zhang</author>
1818
<author email="[email protected]">Michael Jeronimo</author>
1919

20-
<depend>rclpy</depend>
21-
<depend>ros2cli</depend>
22-
2320
<exec_depend>lifecycle_msgs</exec_depend>
21+
<exec_depend>rclpy</exec_depend>
22+
<exec_depend>ros2cli</exec_depend>
2423
<exec_depend>ros2node</exec_depend>
2524
<exec_depend>ros2service</exec_depend>
2625

ros2multicast/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<author email="[email protected]">Mabel Zhang</author>
1818
<author email="[email protected]">Michael Jeronimo</author>
1919

20-
<depend>ros2cli</depend>
20+
<exec_depend>ros2cli</exec_depend>
2121

2222
<test_depend>ament_copyright</test_depend>
2323
<test_depend>ament_flake8</test_depend>

ros2node/package.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@
1717
<author email="[email protected]">Mabel Zhang</author>
1818
<author email="[email protected]">Michael Jeronimo</author>
1919

20-
<depend>ros2cli</depend>
21-
2220
<exec_depend>rclpy</exec_depend>
21+
<exec_depend>ros2cli</exec_depend>
2322

2423
<test_depend>ament_copyright</test_depend>
2524
<test_depend>ament_flake8</test_depend>

ros2param/package.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@
1717
<author email="[email protected]">Mabel Zhang</author>
1818
<author email="[email protected]">Michael Jeronimo</author>
1919

20-
<depend>rcl_interfaces</depend>
21-
<depend>rclpy</depend>
22-
<depend>ros2cli</depend>
23-
20+
<exec_depend>rcl_interfaces</exec_depend>
21+
<exec_depend>rclpy</exec_depend>
22+
<exec_depend>ros2cli</exec_depend>
2423
<exec_depend>ros2node</exec_depend>
2524
<exec_depend>ros2service</exec_depend>
2625

ros2pkg/package.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,13 @@
1717
<author email="[email protected]">Mabel Zhang</author>
1818
<author email="[email protected]">Michael Jeronimo</author>
1919

20-
<depend>python3-importlib-resources</depend>
21-
<depend>ros2cli</depend>
22-
2320
<exec_depend>ament_copyright</exec_depend>
2421
<exec_depend>ament_index_python</exec_depend>
2522
<exec_depend>python3-catkin-pkg-modules</exec_depend>
2623
<exec_depend>python3-empy</exec_depend>
24+
<exec_depend>python3-importlib-resources</exec_depend>
2725
<exec_depend>python3-pkg-resources</exec_depend>
26+
<exec_depend>ros2cli</exec_depend>
2827

2928
<test_depend>ament_flake8</test_depend>
3029
<test_depend>ament_pep257</test_depend>

ros2run/package.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
<author email="[email protected]">Mabel Zhang</author>
1818
<author email="[email protected]">Michael Jeronimo</author>
1919

20-
<depend>ros2cli</depend>
21-
20+
<exec_depend>ros2cli</exec_depend>
2221
<exec_depend>ros2pkg</exec_depend>
2322

2423
<test_depend>ament_copyright</test_depend>

ros2service/package.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@
1717
<author email="[email protected]">Michael Jeronimo</author>
1818
<author email="[email protected]">William Woodall</author>
1919

20-
<depend>rclpy</depend>
21-
<depend>ros2cli</depend>
22-
2320
<exec_depend>python3-yaml</exec_depend>
21+
<exec_depend>rclpy</exec_depend>
22+
<exec_depend>ros2cli</exec_depend>
2423
<exec_depend>rosidl_runtime_py</exec_depend>
2524

2625
<test_depend>ament_copyright</test_depend>

0 commit comments

Comments
 (0)