add resourceExists check to loadEmbeddedTexture before loading texture (#1542) (#1551)

(cherry picked from commit af656e3)

Co-authored-by: John TGZ <[email protected]>

Author: mergify[bot]

rviz_rendering/src/rviz_rendering/mesh_loader_helpers/assimp_loader.cpp

@@ -367,29 +367,33 @@ void AssimpLoader::setLightColorsFromAssimp(
 void AssimpLoader::loadEmbeddedTexture(
   const aiTexture * texture, const std::string & resource_path)
 {
-  if (texture == nullptr) {
-    RVIZ_RENDERING_LOG_ERROR_STREAM("null texture!");
-    return;
-  }
+  // Check if the embedded texture already exists within TextureManager before proceeding to
+  // load it.
+  if (!Ogre::TextureManager::getSingleton().resourceExists(resource_path, ROS_PACKAGE_NAME)) {
+    if (texture == nullptr) {
+      RVIZ_RENDERING_LOG_ERROR_STREAM("null texture!");
+      return;
+    }
+
+    // use the format hint to try to load the image
+    std::string format_hint(
+      texture->achFormatHint,
+      strnlen(texture->achFormatHint, sizeof(texture->achFormatHint)));
 
-  // use the format hint to try to load the image
-  std::string format_hint(
-    texture->achFormatHint,
-    strnlen(texture->achFormatHint, sizeof(texture->achFormatHint)));
-
-  Ogre::DataStreamPtr stream(
-    new Ogre::MemoryDataStream(
-      (unsigned char *)texture->pcData, texture->mWidth));
-
-  try {
-    Ogre::Image image;
-    image.load(stream, format_hint.c_str());
-    Ogre::TextureManager::getSingleton().loadImage(
-      resource_path, ROS_PACKAGE_NAME, image);
-  } catch (Ogre::Exception & e) {
-    RVIZ_RENDERING_LOG_ERROR_STREAM(
-      "Could not load texture [" << resource_path.c_str() <<
-        "] with format hint [" << format_hint << "]: " << e.what());
+    Ogre::DataStreamPtr stream(
+      new Ogre::MemoryDataStream(
+        (unsigned char *)texture->pcData, texture->mWidth));
+
+    try {
+      Ogre::Image image;
+      image.load(stream, format_hint.c_str());
+      Ogre::TextureManager::getSingleton().loadImage(
+        resource_path, ROS_PACKAGE_NAME, image);
+    } catch (Ogre::Exception & e) {
+      RVIZ_RENDERING_LOG_ERROR_STREAM(
+        "Could not load texture [" << resource_path.c_str() <<
+          "] with format hint [" << format_hint << "]: " << e.what());
+    }
   }
 }