Fixed crash when a resource is not available (#1455)

ahcorde · web-flow · commit 170470f5a0e0 · 2025-05-04T21:30:22.000+02:00
Signed-off-by: Alejandro Hernandez Cordero &lt;ahcorde@gmail.com&gt;
diff --git a/rviz_common/src/rviz_common/load_resource.cpp b/rviz_common/src/rviz_common/load_resource.cpp
@@ -50,8 +50,12 @@ namespace rviz_common
 resource_retriever::ResourceSharedPtr getResource(const std::string & resource_path)
 {
   RVIZ_COMMON_LOG_DEBUG("rviz_common::getResource() loading resource: " + resource_path);
-  resource_retriever::Retriever retriever;
-  return retriever.get_shared(resource_path);
+  try {
+    resource_retriever::Retriever retriever;
+    return retriever.get_shared(resource_path);
+  } catch (...) {
+    return nullptr;
+  }
 }
 
 QPixmap loadPixmap(QString url, bool fill_cache)

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,12 @@ namespace rviz_common`
`50`	`50`	`resource_retriever::ResourceSharedPtr getResource(const std::string & resource_path)`
`51`	`51`	`{`
`52`	`52`	`RVIZ_COMMON_LOG_DEBUG("rviz_common::getResource() loading resource: " + resource_path);`
`53`		`- resource_retriever::Retriever retriever;`
`54`		`- return retriever.get_shared(resource_path);`
	`53`	`+ try {`
	`54`	`+ resource_retriever::Retriever retriever;`
	`55`	`+ return retriever.get_shared(resource_path);`
	`56`	`+ } catch (...) {`
	`57`	`+ return nullptr;`
	`58`	`+ }`
`55`	`59`	`}`
`56`	`60`
`57`	`61`	`QPixmap loadPixmap(QString url, bool fill_cache)`