Skip to content

Commit 22951a2

Browse files
committed
Fix to infinite loop of exposeEvent in pyside environment due to impl_->resize() call inside exposeEvent()
1 parent 1069c13 commit 22951a2

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

rviz_rendering/include/rviz_rendering/render_window.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,6 @@ public slots:
139139
// void
140140
// mouseReleaseEvent(QMouseEvent * mouse_event) override;
141141

142-
void
143-
exposeEvent(QExposeEvent * expose_event) override;
144-
145142
bool
146143
event(QEvent * event) override;
147144

rviz_rendering/src/rviz_rendering/render_window.cpp

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,7 @@ RenderWindow::event(QEvent * event)
157157
{
158158
switch (event->type()) {
159159
case QEvent::Resize:
160-
if (this->isExposed()) {
161-
impl_->resize(this->width(), this->height());
162-
}
160+
impl_->resize(this->width(), this->height());
163161
return QWindow::event(event);
164162
case QEvent::UpdateRequest:
165163
this->renderNow();
@@ -182,18 +180,6 @@ RenderWindow::event(QEvent * event)
182180
}
183181
}
184182

185-
void
186-
RenderWindow::exposeEvent(QExposeEvent * expose_event)
187-
{
188-
Q_UNUSED(expose_event);
189-
190-
if (this->isExposed()) {
191-
impl_->resize(this->width(), this->height());
192-
this->renderNow();
193-
}
194-
}
195-
196-
197183
void
198184
RenderWindowOgreAdapter::setOgreCamera(RenderWindow * render_window, Ogre::Camera * ogre_camera)
199185
{

0 commit comments

Comments
 (0)