Correclty load icons of panels with whitespaces in their name (#1241) (#1244)

(cherry picked from commit d390a55)

Co-authored-by: Patrick Roncagliolo <[email protected]>

Author: mergify[bot]

rviz_common/include/rviz_common/factory/pluginlib_factory.hpp

@@ -177,7 +177,9 @@ class PluginlibFactory : public ClassIdRecordingFactory<Type>
       return loadPixmap(default_icon_path);
     }
 
-    auto base_path = "package://" + info.package + "/icons/classes/" + info.name;
+    auto encoded_name = info.name;
+    encoded_name.replace(" ", "%20");
+    auto base_path = "package://" + info.package + "/icons/classes/" + encoded_name;
     QIcon icon = loadPixmap(base_path + ".svg");
     if (icon.isNull()) {
       icon = loadPixmap(base_path + ".png");