include QString (#1298)

Author: mjforan

rviz_common/include/rviz_common/display.hpp

@@ -36,6 +36,7 @@
 
 #include <QIcon>  // NOLINT: cpplint is unable to handle the include order here
 #include <QSet>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "rclcpp/time.hpp"
 

rviz_common/include/rviz_common/display_group.hpp

@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__DISPLAY_GROUP_HPP_
 #define RVIZ_COMMON__DISPLAY_GROUP_HPP_
 
+#include <QString>
+
 #include "rviz_common/display.hpp"
 #include "rviz_common/visibility_control.hpp"
 

rviz_common/include/rviz_common/factory/class_id_recording_factory.hpp

@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__FACTORY__CLASS_ID_RECORDING_FACTORY_HPP_
 #define RVIZ_COMMON__FACTORY__CLASS_ID_RECORDING_FACTORY_HPP_
 
+#include <QString>
+
 #include "./factory.hpp"
 
 namespace rviz_common

rviz_common/include/rviz_common/message_filter_display.hpp

@@ -35,6 +35,8 @@
 #include <memory>
 #include <string>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include <message_filters/subscriber.hpp>
 
 #include "rviz_common/ros_topic_display.hpp"

rviz_common/include/rviz_common/panel.hpp

@@ -33,6 +33,7 @@
 #ifndef RVIZ_COMMON__PANEL_HPP_
 #define RVIZ_COMMON__PANEL_HPP_
 
+#include <QString>
 #include <QWidget>
 
 #include "rviz_common/config.hpp"

rviz_common/include/rviz_common/panel_dock_widget.hpp

@@ -34,6 +34,7 @@
 
 #include <QDockWidget>
 #include <QLabel>
+#include <QString>
 
 #include "rviz_common/config.hpp"
 #include "rviz_common/visibility_control.hpp"

rviz_common/include/rviz_common/properties/bool_property.hpp

@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__PROPERTIES__BOOL_PROPERTY_HPP_
 #define RVIZ_COMMON__PROPERTIES__BOOL_PROPERTY_HPP_
 
+#include <QString>
+
 #include "rviz_common/properties/property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

rviz_common/include/rviz_common/properties/combo_box.hpp

@@ -31,6 +31,7 @@
 #define RVIZ_COMMON__PROPERTIES__COMBO_BOX_HPP_
 
 #include <QComboBox>
+#include <QString>
 
 #include "rviz_common/visibility_control.hpp"
 

rviz_common/include/rviz_common/properties/covariance_property.hpp

@@ -38,6 +38,7 @@
 #include <OgreColourValue.h>
 
 #include <QColor>  // NOLINT cpplint cannot handle include order here
+#include <QString>  // NOLINT cpplint cannot handle include order here
 
 #include "rviz_common/properties/bool_property.hpp"
 #include "rviz_common/visibility_control.hpp"

rviz_common/include/rviz_common/properties/enum_property.hpp

@@ -32,10 +32,11 @@
 #ifndef RVIZ_COMMON__PROPERTIES__ENUM_PROPERTY_HPP_
 #define RVIZ_COMMON__PROPERTIES__ENUM_PROPERTY_HPP_
 
-#include <QStringList>
-
 #include <string>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+#include <QStringList>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/properties/string_property.hpp"
 #include "rviz_common/visibility_control.hpp"