Skip to content

Commit b657b3e

Browse files
committed
[TODO] last attempt to build on Win10 (#640 (comment))
1 parent d176615 commit b657b3e

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

rviz_python_bindings/CMakeLists.txt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,19 @@ list(APPEND shiboken_include_dirs
5757
${tf2_msgs_INCLUDE_DIRS}
5858
${pluginlib_INCLUDE_DIRS}
5959
)
60+
if(WIN32)
61+
list(APPEND shiboken_include_dirs
62+
${console_bridge_INCLUDE_DIRS}
63+
)
64+
endif()
6065
message(STATUS "ROS inlcude dirs: ${shiboken_include_dirs}")
6166
message(STATUS "QT5 inlcude dirs: ${Qt5Core_INCLUDE_DIRS} ${Qt5Widgets_INCLUDE_DIRS} ${Qt5Gui_INCLUDE_DIRS}")
6267
list(APPEND shiboken_include_dirs
6368
${Qt5Core_INCLUDE_DIRS} ${Qt5Widgets_INCLUDE_DIRS} ${Qt5Gui_INCLUDE_DIRS}
6469
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
6570
$<INSTALL_INTERFACE:include>
6671
)
72+
cmake_path(SET shiboken_include_dirs NORMALIZE "${shiboken_include_dirs}")
6773

6874
add_library(rviz_python SHARED
6975
src/visualizer_frame_py.cpp
@@ -72,7 +78,9 @@ add_library(rviz_python SHARED
7278
target_include_directories(rviz_python PUBLIC
7379
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
7480
$<INSTALL_INTERFACE:include>)
75-
target_compile_options(rviz_python PUBLIC -Wl,--no-undefined)
81+
if(NOT WIN32)
82+
target_compile_options(rviz_python PUBLIC -Wl,--no-undefined)
83+
endif()
7684
ament_target_dependencies(rviz_python
7785
rviz_common
7886
Qt5

0 commit comments

Comments
 (0)