[TODO] changes to make rviz_python_bindings working without the need to modify /rviz_common/visualization_frame. To be improved later

Author: KKSTB

rviz_python_bindings/include/rviz_python_bindings/visualizer_frame_py.hpp

@@ -17,10 +17,7 @@ class VisualizerFramePy : public VisualizationFrame
   explicit VisualizerFramePy(
     QWidget * parent = nullptr);
 
-  ~VisualizerFramePy()
-  {
-    ros_client_abstraction_->shutdown();
-  }
+  ~VisualizerFramePy();
 
   bool node_ok();
 

rviz_python_bindings/src/visualizer_frame_py.cpp

@@ -3,10 +3,15 @@
 using namespace rviz_common;
 
 VisualizerFramePy::VisualizerFramePy(QWidget * parent)
-: VisualizationFrame(parent)
+: VisualizationFrame(rviz_common::ros_integration::RosNodeAbstractionIface::WeakPtr(), parent)
 {
   ros_client_abstraction_ = std::make_unique<rviz_common::ros_integration::RosClientAbstraction>();
-  this->rviz_ros_node_ = ros_client_abstraction_->init(0, nullptr, "rviz", false);
+  rviz_ros_node_ = ros_client_abstraction_->init(0, nullptr, "rviz", false);
+}
+
+VisualizerFramePy::~VisualizerFramePy()
+{
+  ros_client_abstraction_->shutdown();
 }
 
 bool VisualizerFramePy::node_ok()