Remove redundant check (#1506) (#1512)

mergify[bot] · ahcorde · web-flow · commit f2df776518bc · 2025-06-30T19:45:55.000+02:00
(cherry picked from commit 21891c0) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
diff --git a/rviz_common/src/rviz_common/properties/property_tree_model.cpp b/rviz_common/src/rviz_common/properties/property_tree_model.cpp
@@ -114,9 +114,6 @@ QModelIndex PropertyTreeModel::parentIndex(const Property * child) const
     return QModelIndex();
   }
   Property * parent = child->getParent();
-  if (parent == root_property_ || !parent) {
-    return QModelIndex();
-  }
   return indexOf(parent);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -114,9 +114,6 @@ QModelIndex PropertyTreeModel::parentIndex(const Property * child) const`
`114`	`114`	`return QModelIndex();`
`115`	`115`	`}`
`116`	`116`	`Property * parent = child->getParent();`
`117`		`- if (parent == root_property_ \|\| !parent) {`
`118`		`- return QModelIndex();`
`119`		`- }`
`120`	`117`	`return indexOf(parent);`
`121`	`118`	`}`
`122`	`119`