remove image transport plugins as dependency

Author: mjforan

.devcontainer/Dockerfile

@@ -20,5 +20,6 @@ RUN apt update && apt install -y \
         python3-pytest-timeout \
         ros-dev-tools
 WORKDIR /ros2_rolling
+ENV ROS_DISTRO="rolling"
 RUN mkdir src && vcs import --input https://raw.githubusercontent.com/ros2/ros2/rolling/ros2.repos src
 RUN apt upgrade -y && rosdep init && rosdep update && rosdep install --from-paths src --ignore-src -y --skip-keys "fastcdr rti-connext-dds-6.0.1 urdfdom_headers"

rviz_default_plugins/CMakeLists.txt

@@ -65,7 +65,6 @@ find_package(gz_math_vendor REQUIRED)
 find_package(gz-math REQUIRED)
 
 find_package(image_transport REQUIRED)
-find_package(image_transport_plugins REQUIRED)
 find_package(interactive_markers REQUIRED)
 find_package(laser_geometry REQUIRED)
 find_package(map_msgs REQUIRED)
@@ -247,7 +246,6 @@ target_include_directories(rviz_default_plugins PUBLIC
 target_link_libraries(rviz_default_plugins PUBLIC
   ${geometry_msgs_TARGETS}
   image_transport::image_transport
-  ${image_transport_plugins_TARGETS}
   interactive_markers::interactive_markers
   laser_geometry::laser_geometry
   ${map_msgs_TARGETS}
@@ -286,7 +284,6 @@ ament_export_targets(rviz_default_plugins HAS_LIBRARY_TARGET)
 ament_export_dependencies(
   geometry_msgs
   image_transport
-  image_transport_plugins
   interactive_markers
   laser_geometry
   map_msgs

rviz_default_plugins/package.xml

@@ -40,7 +40,6 @@
   <depend>geometry_msgs</depend>
   <depend>gz_math_vendor</depend>
   <depend>image_transport</depend>
-  <depend>image_transport_plugins</depend>
   <depend>interactive_markers</depend>
   <depend>laser_geometry</depend>
   <depend>nav_msgs</depend>

rviz_default_plugins/src/rviz_default_plugins/displays/image/image_display.cpp

@@ -69,6 +69,9 @@
 
 #include <rviz_common/logging.hpp> // TODO remove when done
 
+// TODO This may have introduced a segfault upon closing the program, but it is infrequent.
+// It's possible this existed before my changes.
+
 namespace rviz_default_plugins
 {
 namespace displays
@@ -198,7 +201,6 @@ void ImageDisplay::subscribe(){
   // Update the message types to allow in the topic_property_
   ((rviz_common::properties::RosTopicMultiProperty*)topic_property_)->setMessageTypes(message_types);
 
-  RVIZ_COMMON_LOG_INFO("subscribe");
   if (topic_property_->isEmpty()) {
     setStatus(
       rviz_common::properties::StatusProperty::Error, "Topic",