Skip to content

Commit 9fc8ef2

Browse files
restrict usersettings to owner plus some minor eslin fixes
1 parent 4a9ac10 commit 9fc8ef2

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

server/hooks/map-create-to-upsert.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
module.exports = function (upsertQuery) {
55
if (typeof upsertQuery !== 'function') {
6-
console.warn('No `upsertQuery` function was passed to the mapCreateToUpsert hook. Please set params.upsertQuery in the hook context to dynamically declare the function.');
6+
throw new Error('No `upsertQuery` function was passed to the mapCreateToUpsert hook. Please set params.upsertQuery in the hook context to dynamically declare the function.');
77
}
88

99
return function mapCreateToUpsert (context) {

server/seeder/development/usersettings.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
1-
const seedHelpers = require('../../helper/seed-helpers');
2-
const _ = require('lodash');
1+
const { size, keys } = require('lodash');
32

43
let userKeys = [];
54

65
// eslint-disable-next-line no-unused-vars
76
module.exports = (seederstore) => {
8-
userKeys = _.keys(seederstore.users);
7+
userKeys = keys(seederstore.users);
98
return {
109
services: [{
1110
path: 'usersettings',
12-
count: _.size(seederstore.users),
11+
count: size(seederstore.users),
1312
template: {
1413
userId: () => {
1514
return userKeys.pop();

server/services/usersettings/usersettings.hooks.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,15 @@ module.exports = {
1212
return { userId: data.userId };
1313
})
1414
],
15-
update: [],
16-
patch: [],
17-
remove: []
15+
update: [
16+
restrictToOwner()
17+
],
18+
patch: [
19+
restrictToOwner()
20+
],
21+
remove: [
22+
restrictToOwner()
23+
]
1824
},
1925
after: {
2026
all: [],

0 commit comments

Comments
 (0)