Skip to content

Commit 053f2ad

Browse files
committed
update embed-to-anchor
1 parent 1d6b4c8 commit 053f2ad

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
},
5454
"dependencies": {
5555
"body-parser": "~1.18.2",
56-
"cheerio": "^1.0.0-rc.2",
5756
"compression": "~1.7.1",
5857
"cors": "~2.8.4",
5958
"crypto": "~1.0.1",
@@ -103,7 +102,7 @@
103102
"mongoose": "~4.13.2",
104103
"multer": "~1.3.0",
105104
"node-sass": "~4.7.2",
106-
"quill-url-embeds": "^1.0.6",
105+
"quill-url-embeds": "^1.0.9",
107106
"raven": "~2.4.0",
108107
"request": "~2.83.0",
109108
"request-promise": "~4.2.2",

server/hooks/xss.js

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,10 @@
11
const sanitizeHtml = require('sanitize-html');
2-
// const utils = require('quill-url-embeds');
2+
const embedToAnchor = require('quill-url-embeds/dist/embed-to-anchor');
33
const _ = require('lodash');
4-
const cheerio = require('cheerio');
54

65
function clean (dirty) {
76
// Convert embeds to a-tags
8-
// dirty = utils.embedToAnchor(dirty);
9-
const $ = cheerio.load(dirty);
10-
$('div[data-url-embed]').each((i, el) => {
11-
let url = el.attribs['data-url-embed'];
12-
let aTag = $(`<a href="${url}" target="_blank" data-url-embed>${url}</a>`);
13-
$(el).replaceWith(aTag);
14-
})
15-
dirty = $('body').html();
16-
7+
dirty = embedToAnchor(dirty);
178
dirty = sanitizeHtml(dirty, {
189
allowedTags: ['iframe', 'img', 'p', 'br', 'b', 'i', 'em', 'strong', 'a', 'pre', 'ul', 'li', 'ol', 'span'],
1910
allowedAttributes: {

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4405,9 +4405,9 @@ quill-delta@^3.6.2:
44054405
extend "^3.0.1"
44064406
fast-diff "1.1.2"
44074407

4408-
quill-url-embeds@^1.0.6:
4409-
version "1.0.6"
4410-
resolved "https://registry.yarnpkg.com/quill-url-embeds/-/quill-url-embeds-1.0.6.tgz#e2b9f8ea73d254efd5f90578c79210e787fad068"
4408+
quill-url-embeds@^1.0.9:
4409+
version "1.0.9"
4410+
resolved "https://registry.yarnpkg.com/quill-url-embeds/-/quill-url-embeds-1.0.9.tgz#883b5c3ae07f29eb7ee36d98f89a403f1314f7c8"
44114411
dependencies:
44124412
axios "^0.18.0"
44134413
babel-polyfill "^6.26.0"

0 commit comments

Comments
 (0)