Fix lint errors

Author: roschaefer

features/env/database.js

@@ -1,37 +1,35 @@
-const {Before, AfterAll, BeforeAll} = require('cucumber');
+/* eslint no-console: off */
+const { Before, AfterAll } = require('cucumber');
 const mongoose = require('mongoose');
 const sinon = require('sinon');
 
 const userSchema = require('../../human-connection-api/server/models/users.model.js');
 const contributionSchema = require('../../human-connection-api/server/models/contributions.model.js');
 
-mongoose.connect("mongodb://localhost/hc_api_test");
+mongoose.connect('mongodb://localhost/hc_api_test');
 const db = mongoose.connection;
 
-let app = sinon.stub();
-sinon.stub(app, 'get').callsFake(function() {
-  return mongoose;
-});
+const app = sinon.stub();
+sinon.stub(app, 'get').callsFake(() => mongoose);
 
-let User, Contribution;
+let User;
+let Contribution;
 db.on('error', console.error.bind(console, 'connection error:'));
-db.once('open', function() {
+db.once('open', () => {
   // initialize models needed in step definitions
   User = userSchema(app);
   Contribution = contributionSchema(app);
 });
 
 // Asynchronous Promise
-Before(function(_, callback) {
-  let promises = [User, Contribution].map((model) => {
-    return model.remove();
-  });
+Before((_, callback) => {
+  const promises = [User, Contribution].map(model => model.remove());
   Promise.all(promises).then(() => {
     callback();
   });
 });
 
-AfterAll(function(callback) {
+AfterAll((callback) => {
   db.close();
   callback();
 });

features/env/hooks.js

@@ -1,16 +1,17 @@
-const {AfterAll, BeforeAll} = require('cucumber');
+/* eslint no-console: off */
+const { AfterAll, BeforeAll } = require('cucumber');
 const { spawn } = require('child_process');
 const waitOn = require('wait-on');
 
 let hcApi;
 
 // Asynchronous Callback
-BeforeAll({timeout: 30*1000}, function (callback) {
+BeforeAll({ timeout: 30 * 1000 }, (callback) => {
   hcApi = spawn('node', ['server/'], {
     cwd: './human-connection-api/',
     env: {
-      'NODE_ENV': 'test'
-    }
+      NODE_ENV: 'test',
+    },
   });
 
   hcApi.stdout.on('data', (data) => {
@@ -21,15 +22,15 @@ BeforeAll({timeout: 30*1000}, function (callback) {
     console.log(`stderr: ${data}`);
   });
 
-  waitOn({ resources: ['tcp:3030'], timeout: 30000 }, function (err) {
-    if (err) { return handleError(err); }
-    callback();
+  waitOn({ resources: ['tcp:3030'], timeout: 30000 }, (err) => {
+    if (err) throw (err);
+    return callback();
   });
 });
 
 // Asynchronous Promise
-AfterAll(function () {
+AfterAll(() => {
   // perform some shared teardown
   hcApi.kill();
-  return Promise.resolve()
+  return Promise.resolve();
 });

features/step_definitions/steps.js

@@ -1,40 +1,41 @@
 const { Given, When, Then } = require('cucumber');
 const fetch = require('node-fetch');
 const mongoose = require('mongoose');
-const expect = require('chai').expect;
+const { expect } = require('chai');
 // Hack: Directly accessing the default password hashing function
 const encrypt = require('../../node_modules/feathers-authentication-local/lib/utils/hash');
 
-let currentUser, currentUserPassword, httpResponse, currentUserAccessToken;
+let currentUser;
+let currentUserPassword;
+let httpResponse;
+let currentUserAccessToken;
 const hcBackendUrl = 'http://localhost:3030';
 
 
-function authenticate(email, plainTextPassword){
+function authenticate(email, plainTextPassword) {
   const formData = {
-    email: email,
+    email,
     password: plainTextPassword,
     strategy: 'local',
   };
   return fetch(`${hcBackendUrl}/authentication`, {
     method: 'post',
     body: JSON.stringify(formData),
     headers: { 'Content-Type': 'application/json' },
-  }).then(response => response.json()).then((json) => {
-    return json.accessToken;
-  });
+  }).then(response => response.json()).then(json => json.accessToken);
 }
 
-Given('the Human Connection API is up and running', function () {
+Given('the Human Connection API is up and running', () => {
   // Just documentation
 });
 
-Given("there is a 3rd party application running, e.g. 'Democracy'", function () {
+Given("there is a 3rd party application running, e.g. 'Democracy'", () => {
   // Just documentation
 });
 
-Given('there is an organization in Human Connection with these credentials:', function (dataTable) {
+Given('there is an organization in Human Connection with these credentials:', (dataTable) => {
   const User = mongoose.model('users');
-  params = dataTable.hashes()[0];
+  const params = dataTable.hashes()[0];
   return encrypt(params.password).then((hashedPassword) => {
     currentUserPassword = params.password; // remember plain text password
     params.password = hashedPassword; // hashed password goes into db
@@ -43,22 +44,20 @@ Given('there is an organization in Human Connection with these credentials:', fu
   });
 });
 
-Given('I am authenticated', function () {
-  return authenticate(currentUser.email, currentUserPassword).then((accessToken) => {
-    currentUserAccessToken = accessToken;
-  });
-});
+Given('I am authenticated', () => authenticate(currentUser.email, currentUserPassword).then((accessToken) => {
+  currentUserAccessToken = accessToken;
+}));
 
-Given('my user account is verified', function () {
+Given('my user account is verified', () => {
   // Write code here that turns the phrase above into concrete actions
   currentUser.isVerified = true;
   return currentUser.save();
 });
 
-When('I send a POST request to {string} with:', function (route, body, callback) {
-  let params = {
+When('I send a POST request to {string} with:', (route, body, callback) => {
+  const params = {
     method: 'post',
-    body: body,
+    body,
     headers: { 'Content-Type': 'application/json' },
   };
   if (currentUserAccessToken) {
@@ -70,15 +69,15 @@ When('I send a POST request to {string} with:', function (route, body, callback)
   });
 });
 
-Then('there is an access token in the response:', function (docString) {
+Then('there is an access token in the response:', () => {
   expect(httpResponse.accessToken).to.be.a('string');
   expect(httpResponse.accessToken.length).to.eq(342);
 });
 
-Then('a new post should be created', function (callback) {
+Then('a new post should be created', (callback) => {
   const Contribution = mongoose.model('contributions');
-  Contribution.find({}, function(err, contributions){
-    if(err) throw(err);
+  Contribution.find({}, (err, contributions) => {
+    if (err) throw (err);
     expect(contributions).to.have.lengthOf(1);
     expect(contributions[0].type).to.eq('post');
     callback();

package.json

@@ -18,7 +18,7 @@
   "author": "Robert Schaefer <[email protected]>",
   "license": "MIT",
   "scripts": {
-    "lint": "eslint --ext mjs .",
+    "lint": "eslint features/ index.mjs",
     "start": "node --experimental-modules index.mjs",
     "test": "cucumber-js"
   },