added debug env var on dev mode and some additional logging and better seeding

Author: appinteractive

package.json

@@ -39,9 +39,9 @@
     "start": "concurrently 'mongod' 'wait-on tcp:27017 && NODE_ENV=production node server/'",
     "start:win": "concurrently \"mongod\" \"wait-on tcp:27017 &&SET NODE_ENV=production&& node server/\"",
     "dev:debug": "npm run clear && concurrently '$npm_package_config_mongoDev' 'wait-on tcp:27017 && NODE_ENV=development nodemon --inspect server/'",
-    "dev": "npm run clear && concurrently '$npm_package_config_mongoDev' 'wait-on tcp:27017 && NODE_ENV=development nodemon server/'",
-    "dev:noseed": "concurrently 'mongod --dbpath data' 'wait-on tcp:27017 && NODE_ENV=development nodemon server/'",
-    "dev:win": "npm run clear && concurrently \"mongod --dbpath data\" \"wait-on tcp:27017&&SET NODE_ENV=development&& nodemon --inspect server/\"",
+    "dev": "npm run clear && concurrently '$npm_package_config_mongoDev' 'wait-on tcp:27017 && NODE_ENV=development DEBUG=feathers nodemon server/'",
+    "dev:noseed": "concurrently 'mongod --dbpath data' 'wait-on tcp:27017 && NODE_ENV=development DEBUG=feathers nodemon server/'",
+    "dev:win": "npm run clear && concurrently \"mongod --dbpath data\" \"wait-on tcp:27017&&SET NODE_ENV=development&&SET DEBUG=feathers&& nodemon --inspect server/\"",
     "mocha": "npm run clear && $npm_package_config_concurrently '$npm_package_config_mongoDev &>/dev/null' 'wait-on tcp:27017 && NODE_ENV=test $npm_package_config_mocha'",
     "coverage": "npm run clear && $npm_package_config_concurrently '$npm_package_config_mongoDev &>/dev/null' 'wait-on tcp:27017 && NODE_ENV=test istanbul cover $npm_package_config_mochaCoverage'"
   },
@@ -99,6 +99,7 @@
     "shortid": "~2.2.8",
     "slug": "~0.9.1",
     "trunc-html": "^1.1.2",
+    "valid-url": "^1.0.9",
     "winston": "~3.0.0-rc1"
   },
   "devDependencies": {

server/hooks/save-remote-images.js

@@ -2,11 +2,13 @@
 // For more information on hooks see: http://docs.feathersjs.com/api/hooks.html
 
 const errors = require('feathers-errors');
+const { isEmpty } = require('lodash');
 const fs = require('fs');
 const path = require('path');
 const request = require('request');
 const faker = require('faker');
 const mime = require('mime/lite');
+// const validUrl = require('valid-url');
 
 module.exports = function (options = []) { // eslint-disable-line no-unused-vars
   return function async (hook) {
@@ -28,10 +30,19 @@ module.exports = function (options = []) { // eslint-disable-line no-unused-vars
 
         // save all given fields and update the hook data
         options.forEach((field) => {
-          if (!hook.data[field] || (typeof hook.data[field] === 'string' && hook.data[field].search(uploadsUrl) >= 0)) {
+          if (isEmpty(hook.data[field]) || (typeof hook.data[field] === 'string' && hook.data[field].search(uploadsUrl) >= 0)) {
             // skip invalid and local data
+            // hook.app.debug(`skip invalid and local data: ${field} - ${hook.data[field]}`);
             return;
           }
+          // cant only check for validUrl as we also get blobs
+          // if (!validUrl.isWebUri(hook.data[field])) {
+          //   // cancel on invalid image url
+          //   hook.app.debug(`cancel on invalid image url: ${hook.data[field]}`);
+          //   return;
+          // }
+          hook.app.debug(`try to get image: ${hook.data[field]}`);
+
           loading++;
           imgCount++;
           // TODO: fix that to use the data _id or somethink similar
@@ -95,7 +106,7 @@ module.exports = function (options = []) { // eslint-disable-line no-unused-vars
             });
           }
 
-          hook.app.debug('Downloading', hook.data[field]);
+          hook.app.debug(`Downloading: ${hook.data[field]}`);
         });
 
         if (imgCount > 0 && loading <= 0) {
@@ -104,7 +115,7 @@ module.exports = function (options = []) { // eslint-disable-line no-unused-vars
         } else if (!imgCount) {
           resolve(hook);
         }
-      } catch(err) {
+      } catch (err) {
         // reject(err);
         if (imgCount) {
           hook.app.error('Thumbnail download failed');

server/seeder/development/users.js

@@ -1,4 +1,5 @@
 const seedHelpers = require('../../helper/seed-helpers');
+const faker = require('faker');
 
 // eslint-disable-next-line no-unused-vars
 module.exports = (seederstore) => {
@@ -13,7 +14,7 @@ module.exports = (seederstore) => {
         slug: '{{lorem.slug}}',
         isnothere: true,
         timezone: 'Europe/Berlin',
-        avatar: '{{internet.avatar}}',
+        avatar: () => seedHelpers.randomItem([faker.internet.avatar(), null]),
         isVerified : true,
         role : 'user',
         badgeIds: () => seedHelpers.randomItems(seederstore.badges, '_id', 0, seederstore.badges.length),
@@ -24,4 +25,4 @@ module.exports = (seederstore) => {
       }
     }]
   };
-};
+};

server/seeder/index.js

@@ -21,6 +21,7 @@ let configs = [...baseConfigs, ...developmentConfigs];
 // seed service and add results to the seeder store
 const seedAndAssign = async (config, seeder, app) => {
   const key = config.path;
+  app.debug(`>> SEEDING: ${key}`);
   try {
     const res = await seeder.seed(config);
     if (_.isEmpty(seederstore[key])) {

yarn.lock

@@ -5564,6 +5564,10 @@ valid-data-url@^0.1.4:
   version "0.1.4"
   resolved "https://registry.yarnpkg.com/valid-data-url/-/valid-data-url-0.1.4.tgz#9480d7eb8d4f5675a8ad774e51068be7b0aef410"
 
+valid-url@^1.0.9:
+  version "1.0.9"
+  resolved "https://registry.yarnpkg.com/valid-url/-/valid-url-1.0.9.tgz#1c14479b40f1397a75782f115e4086447433a200"
+
 validate-npm-package-license@^3.0.1:
   version "3.0.1"
   resolved "https://registry.yarnpkg.com/validate-npm-package-license/-/validate-npm-package-license-3.0.1.tgz#2804babe712ad3379459acfbe24746ab2c303fbc"