Merge pull request #581 from rosenbjerg/include-more-guid-chars-in-pipe-path

Include more guid chars in pipe path

Author: rosenbjerg

FFMpegCore.Test/ArgumentBuilderTest.cs

@@ -1,13 +1,15 @@
 using System.Drawing;
 using FFMpegCore.Arguments;
 using FFMpegCore.Enums;
+using FFMpegCore.Pipes;
 
 namespace FFMpegCore.Test;
 
 [TestClass]
 public class ArgumentBuilderTest
 {
     private readonly string[] _concatFiles = { "1.mp4", "2.mp4", "3.mp4", "4.mp4" };
+    private readonly int _macOsMaxPipePathLength = 104;
     private readonly string[] _multiFiles = { "1.mp3", "2.mp3", "3.mp3", "4.mp3" };
 
     [TestMethod]
@@ -703,4 +705,18 @@ public void Audible_Aax_Test()
         var arg = new AudibleEncryptionKeyArgument("62689101");
         Assert.AreEqual("-activation_bytes 62689101", arg.Text);
     }
+
+    [TestMethod]
+    public void InputPipe_MaxLength_ShorterThanMacOSMax()
+    {
+        var pipePath = new InputPipeArgument(new StreamPipeSource(Stream.Null)).PipePath;
+        Assert.IsLessThan(104, pipePath.Length);
+    }
+
+    [TestMethod]
+    public void OutputPipe_MaxLength_ShorterThanMacOSMax()
+    {
+        var pipePath = new OutputPipeArgument(new StreamPipeSink(Stream.Null)).PipePath;
+        Assert.IsLessThan(_macOsMaxPipePathLength, pipePath.Length);
+    }
 }

FFMpegCore/FFMpeg/Arguments/PipeArgument.cs

@@ -11,7 +11,7 @@ public abstract class PipeArgument
 
     protected PipeArgument(PipeDirection direction)
     {
-        PipeName = PipeHelpers.GetUnqiuePipeName();
+        PipeName = PipeHelpers.GetUniquePipeName();
         _direction = direction;
     }
 

FFMpegCore/FFMpeg/Pipes/PipeHelpers.cs

@@ -4,9 +4,9 @@ namespace FFMpegCore.Pipes;
 
 internal static class PipeHelpers
 {
-    public static string GetUnqiuePipeName()
+    public static string GetUniquePipeName()
     {
-        return $"FFMpegCore_{Guid.NewGuid().ToString("N").Substring(0, 5)}";
+        return $"FFMpegCore_{Guid.NewGuid().ToString("N").Substring(0, 16)}";
     }
 
     public static string GetPipePath(string pipeName)