WS-2609: Add Checkstyle and PMD. Finish rewriting tests. Address Checkstyle, PMD and Sonar issues.

Author: seth-mg

annotations/src/main/java/com/basistech/rosette/annotations/JacksonMixin.java

@@ -1,5 +1,5 @@
 /*
-* Copyright 2017-2022 Basis Technology Corp.
+* Copyright 2017 Basis Technology Corp.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.

annotations/src/main/java/com/basistech/rosette/annotations/JacksonMixinProcessor.java

@@ -1,5 +1,5 @@
 /*
-* Copyright 2017 Basis Technology Corp.
+* Copyright 2022 Basis Technology Corp.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -48,6 +48,7 @@
 public class JacksonMixinProcessor extends AbstractProcessor {
 
     private static final String PACKAGE_NAME = "com.basistech.rosette.apimodel.jackson";
+    private static final String VALUE = "value";
 
     private ProcessingEnvironment processingEnvironment;
 
@@ -58,6 +59,7 @@ public synchronized void init(ProcessingEnvironment processingEnvironment) {
     }
 
     @Override
+    @SuppressWarnings("java:S3516") // From the Javadoc:  "A processor may always return the same boolean value..."
     public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnvironment) {
         if (roundEnvironment.getElementsAnnotatedWith(JacksonMixin.class).isEmpty()) {
             return true;
@@ -76,14 +78,14 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment
                         .classBuilder(typeElement.getSimpleName().toString() + "Mixin")
                         .addModifiers(Modifier.PUBLIC, Modifier.ABSTRACT)
                         .addAnnotation(AnnotationSpec.builder(JsonTypeName.class)
-                                .addMember("value", "$S", typeElement.getSimpleName())
+                                .addMember(VALUE, "$S", typeElement.getSimpleName())
                                 .build())
                         .addAnnotation(AnnotationSpec.builder(JsonDeserialize.class)
                                 .addMember("builder", CodeBlock.builder()
                                         .add(elementQualifiedName + "." + elementSimpleName + "Builder.class").build())
                                 .build())
                         .addAnnotation(AnnotationSpec.builder(JsonInclude.class)
-                                .addMember("value", CodeBlock.builder()
+                                .addMember(VALUE, CodeBlock.builder()
                                         .add("JsonInclude.Include.NON_NULL").build())
                                 .build())
                         .addType(TypeSpec
@@ -119,7 +121,7 @@ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment
                 .classBuilder("MixinUtil")
                 .addModifiers(Modifier.PUBLIC, Modifier.FINAL)
                 .addAnnotation(AnnotationSpec.builder(SuppressWarnings.class)
-                        .addMember("value", "$S", "PMD")
+                        .addMember(VALUE, "$S", "PMD")
                         .build())
                 .addMethod(methodSpecBuilder.build());
         try {

api/src/main/java/com/basistech/rosette/api/HttpRosetteAPI.java

@@ -1,5 +1,5 @@
 /*
-* Copyright 2017-2022 Basis Technology Corp.
+* Copyright 2022 Basis Technology Corp.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -177,6 +177,7 @@ private static byte[] getBytes(InputStream is) throws IOException {
         }
     }
 
+    @SuppressWarnings("java:HttpClient_must_be_closed") // This library requires keeping the connection open.
     private void initClient(String key, List<Header> additionalHeaders) {
         HttpClientBuilder builder = HttpClients.custom();
         PoolingHttpClientConnectionManager cm = new PoolingHttpClientConnectionManager();

api/src/test/java/com/basistech/rosette/api/BasicTest.java

@@ -1,5 +1,5 @@
 /*
-* Copyright 2017-2022 Basis Technology Corp.
+* Copyright 2022 Basis Technology Corp.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.

api/src/test/java/com/basistech/rosette/api/DevRosetteAPITest.java

@@ -1,5 +1,5 @@
 /*
-* Copyright 2017-2022 Basis Technology Corp.
+* Copyright 2022 Basis Technology Corp.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.

api/src/test/java/com/basistech/rosette/api/InvalidErrorTest.java

@@ -1,5 +1,5 @@
 /*
-* Copyright 2017-2022 Basis Technology Corp.
+* Copyright 2022 Basis Technology Corp.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.