Merge pull request #228 from rosette-api/NO-JIRA-fix-jenkins-not-failing-build

no-jira: fix jenkins skipping failed maven command return code

Author: Katsuya-Tomioka

CI.Jenkinsfile

@@ -1,13 +1,23 @@
 node ("docker-light") {
     def sourceDir = pwd()
     try {
+        def mavenLocalRepo = "$JENKINS_HOME/maven-local-repositories/executor-$EXECUTOR_NUMBER"
         stage("Clean up") {
             step([$class: 'WsCleanup'])
+            sh "rm -rf $mavenLocalRepo"
         }
         stage("Checkout Code") {
             checkout scm
         }
-        stage("Maven Build") {
+        stage("Build") {
+            withMaven(maven: "Basis",
+                    mavenLocalRepo: mavenLocalRepo,
+                    publisherStrategy: "EXPLICIT") {
+                sh "mvn clean verify"
+            }
+
+        }
+        stage("Test with Docker") {
             withSonarQubeEnv {
                 mySonarOpts="-Dsonar.login=${env.SONAR_AUTH_TOKEN} -Dsonar.host.url=${env.SONAR_HOST_URL}"
                  if ("${env.CHANGE_BRANCH}" != "null") {
@@ -23,9 +33,11 @@ node ("docker-light") {
                              apt-get install -y git && \
                              pushd /source && \
                              /opt/maven-basis/bin/mvn --batch-mode clean install sonar:sonar $mySonarOpts; \
+                             maven_ret=\\\$?; \
                              echo && \
                              echo [INFO] Set file permissions to UID and GID of jenkins user for cleanup. && \
-                             chown -R 9960:9960 /source\""
+                             chown -R 9960:9960 /source && \
+                             exit \\\$maven_ret\""
             }
         }
         postToTeams(true)

Jenkinsfile

@@ -1,12 +1,22 @@
 node ("docker-light") {
     def SOURCEDIR = pwd()
     try {
+        def mavenLocalRepo = "$JENKINS_HOME/maven-local-repositories/executor-$EXECUTOR_NUMBER"
         stage("Clean up") {
             step([$class: 'WsCleanup'])
+            sh "rm -rf $mavenLocalRepo"
         }
         stage("Checkout Code") {
             checkout scm
         }
+        stage("Build") {
+            withMaven(maven: "Basis",
+                    mavenLocalRepo: mavenLocalRepo,
+                    publisherStrategy: "EXPLICIT") {
+                sh "mvn clean verify"
+            }
+
+        }
         stage("Test with Docker") {
             echo "${env.ALT_URL}"
             def useUrl = ("${env.ALT_URL}" == "null") ? "${env.BINDING_TEST_URL}" : "${env.ALT_URL}"

json/src/main/java/com/basistech/rosette/apimodel/jackson/recordsimilaritydeserializers/RecordSimilarityDeserializerUtilities.java

@@ -46,7 +46,7 @@ static Map<String, RecordSimilarityField> parseRecord(JsonNode jsonNode, @Valid
             if (fields.containsKey(fieldName)) {
                 final RecordSimilarityFieldInfo fieldInfo = fields.get(fieldName);
                 final RecordSimilarityField fieldData;
-                if (fieldInfo == null) {
+                if (fieldInfo.getType() == null) {
                     throw new IllegalArgumentException("Unspecified field type for: " + fieldName);
                 }
                 switch (fieldInfo.getType()) {