Skip to content

Commit d753839

Browse files
authored
Merge pull request #150 from Katsuya-Tomioka/WS-1693
WS-1693: add includePermID in EntitiesOptions
2 parents 61e929c + 28d3860 commit d753839

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

json/src/test/java/com/basistech/rosette/apimodel/PolymorphicRequestTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,17 @@ public void testRequestTypes() throws Exception {
4141
json = "{\"content\": \"what is my type\", \"language\": \"eng\", \"options\": {\"includeDBpediaType\": true, \"calculateConfidence\": true}}";
4242
request = mapper.readValue(json, new TypeReference<DocumentRequest<EntitiesOptions>>() { });
4343
assertTrue(request instanceof DocumentRequest);
44+
assertNull(((DocumentRequest<EntitiesOptions>) request).getOptions().getIncludePermID());
45+
46+
json = "{\"content\": \"what is my type\", \"language\": \"eng\", \"options\": {\"includeDBpediaType\": true, \"calculateConfidence\": true, \"includePermID\": true}}";
47+
request = mapper.readValue(json, new TypeReference<DocumentRequest<EntitiesOptions>>() { });
48+
assertTrue(request instanceof DocumentRequest);
49+
assertTrue(((DocumentRequest<EntitiesOptions>) request).getOptions().getIncludePermID());
50+
51+
json = "{\"content\": \"what is my type\", \"language\": \"eng\", \"options\": {\"includeDBpediaType\": true, \"calculateConfidence\": true, \"includePermID\": false}}";
52+
request = mapper.readValue(json, new TypeReference<DocumentRequest<EntitiesOptions>>() { });
53+
assertTrue(request instanceof DocumentRequest);
54+
assertFalse(((DocumentRequest<EntitiesOptions>) request).getOptions().getIncludePermID());
4455

4556
json = "{\"name1\": {\"text\": \"Joe\"}, \"name2\": {\"text\": \"Geo\"}}";
4657
request = mapper.readValue(json, NameSimilarityRequest.class);

model/src/main/java/com/basistech/rosette/apimodel/EntitiesOptions.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,9 @@ public class EntitiesOptions extends Options {
6161
* @retrun the includeDBpediaType flag.
6262
*/
6363
private final Boolean includeDBpediaType;
64+
65+
/**
66+
* @return the includePermID flag.
67+
*/
68+
private final Boolean includePermID;
6469
}

0 commit comments

Comments
 (0)