Skip to content

Commit 53a1e52

Browse files
committed
unit tests
1 parent f9bdbcd commit 53a1e52

File tree

6 files changed

+31
-13
lines changed

6 files changed

+31
-13
lines changed

examples/language.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
$customHeaders = [];
2323
$customHeaders[0] = $appHeader;
2424
$params->set('content', $content);
25-
//$params->loadCustomHeaders($customHeaders);
25+
$params->loadCustomHeaders($customHeaders);
2626

2727
try {
2828
$result = $api->language($params);

source/rosette/api/Api.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,11 +332,15 @@ private function callEndpoint($parameters, $subUrl)
332332
$resultObject = '';
333333

334334
// if custom headers exist, add them
335-
/*if($parameters->customHeaders != null){
335+
if($parameters->customHeaders != null){
336336
foreach ($parameters->customHeaders as $key => $value) {
337-
array_push($this->headers, $value);
337+
if(strpos($value, "X") === 0 && strpos($value, "-") === 1){
338+
array_push($this->headers, $value);
339+
} else {
340+
throw new RosetteException("Custom headers must start with \"X-\"");
341+
}
338342
}
339-
}*/
343+
}
340344

341345
if (strlen($parameters->getMultiPartContent()) > 0) {
342346
$content = $parameters->getMultiPartContent();

source/rosette/api/DocumentParameters.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class DocumentParameters extends RosetteParamsSetBase
5656
/**
5757
* @var array customHeaders to allow user to provide custom headers for an API request
5858
*/
59-
//public $customHeaders;
59+
public $customHeaders;
6060

6161
/**
6262
* Constructor.
@@ -171,8 +171,8 @@ public function loadDocumentString($stringData, $multiPart = false)
171171
* @throws RosetteException
172172
*/
173173

174-
/*public function loadCustomHeaders($headers)
174+
public function loadCustomHeaders($headers)
175175
{
176176
$this->customHeaders = $headers;
177-
}*/
177+
}
178178
}

source/rosette/api/NameSimilarityParameters.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class NameSimilarityParameters extends RosetteParamsSetBase
3737
/**
3838
* @var array customHeaders to allow user to provide custom headers for an API request
3939
*/
40-
//public $customHeaders;
40+
public $customHeaders;
4141
/**
4242
* constructor.
4343
*
@@ -82,8 +82,8 @@ public function validate()
8282
* @throws RosetteException
8383
*/
8484

85-
/*public function loadCustomHeaders($headers)
85+
public function loadCustomHeaders($headers)
8686
{
8787
$this->customHeaders = $headers;
88-
}*/
88+
}
8989
}

source/rosette/api/NameTranslationParameters.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class NameTranslationParameters extends RosetteParamsSetBase
6161
/**
6262
* @var array customHeaders to allow user to provide custom headers for an API request
6363
*/
64-
//public $customHeaders;
64+
public $customHeaders;
6565
/**
6666
* constructor.
6767
*/
@@ -100,8 +100,8 @@ public function validate()
100100
* @throws RosetteException
101101
*/
102102

103-
/*public function loadCustomHeaders($headers)
103+
public function loadCustomHeaders($headers)
104104
{
105105
$this->customHeaders = $headers;
106-
}*/
106+
}
107107
}

spec/rosette/api/ApiSpec.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,4 +272,18 @@ public function it_fails_with_non_200_response($params, $request)
272272
$this->setMockRequest($request);
273273
$this->shouldThrow('rosette\api\RosetteException')->duringRelationships($params);
274274
}
275+
276+
public function it_fails_with_incorrectly_formatted_custom_header($params, $request)
277+
{
278+
$params->beADoubleOf('\rosette\api\DocumentParameters');
279+
$params->contentUri = 'http://some.dummysite.com';
280+
$appHeader = [];
281+
$appHeader = "RosetteAPI-App: php-app";
282+
$customHeaders = [];
283+
$customHeaders[0] = $appHeader;
284+
$params->set('content', "some content");
285+
$params->loadCustomHeaders($customHeaders);
286+
$this->shouldThrow('rosette\api\RosetteException')->duringLanguage($params);
287+
288+
}
275289
}

0 commit comments

Comments
 (0)