WS-1138 Allow name deduplication threshold to be null as default (#65)

Author: bwsawyer

rosette/api.py

@@ -3,7 +3,7 @@
 """
 Python client for the Rosette API.
 
-Copyright (c) 2014-2015 Basis Technology Corporation.
+Copyright (c) 2014-2017 Basis Technology Corporation.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -278,7 +278,7 @@ class NameDeduplicationParameters(_DocumentParamSetBase):
     """Parameter object for C{name-deduplication} endpoint.
     Required:
     C{names} A list of C{name} objects
-    C{threshold} Threshold to use to restrict cluster size
+    C{threshold} Threshold to use to restrict cluster size. Can be null to use default value.
     """
 
     def __init__(self):
@@ -287,12 +287,11 @@ def __init__(self):
 
     def validate(self):
         """Internal. Do not use."""
-        for option in ("names", "threshold"):  # required
-            if self[option] is None:
-                raise RosetteException(
-                    "missingParameter",
-                    "Required Name De-Duplication parameter, " + option + ", not supplied",
-                    repr(option))
+        if self["names"] is None:  # required
+            raise RosetteException(
+                "missingParameter",
+                "Required Name De-Duplication parameter, names, not supplied",
+                repr("names"))
 
 
 class EndpointCaller:

tests/test_rosette_api.py

@@ -462,15 +462,6 @@ def test_name_deduplicatation_parameters(api, json_response):
 
     params["names"] = ["John Smith", "Johnathon Smith", "Fred Jones"]
 
-    with pytest.raises(RosetteException) as e_rosette:
-        result = api.name_deduplication(params)
-
-    assert e_rosette.value.status == 'missingParameter'
-    assert e_rosette.value.message == ('Required Name De-Duplication parameter,'
-                                       ' threshold, not supplied')
-
-    params["threshold"] = 0.75
-
     result = api.name_deduplication(params)
     assert result["name"] == "Rosette API"