Skip to content

Commit 8a53583

Browse files
RLPNC-5319: update address example, support unfielded addresses
1 parent 3f3e1aa commit 8a53583

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

examples/address_similarity.rb

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,7 @@
1818
state: 'DC',
1919
post_code: '20500'
2020
)
21-
address2 = AddressParameter.new(
22-
house_number: '160',
23-
road: 'Pennsilvana Avenue',
24-
city: 'Washington',
25-
state: 'D.C.',
26-
post_code: '20500'
27-
)
21+
address2 = '160 Pennsilvana Avenue, Washington, D.C., 20500'
2822
params = AddressSimilarityParameters.new(address1, address2)
2923
response = rosette_api.get_address_similarity(params)
3024
puts JSON.pretty_generate(response)

lib/address_similarity_parameters.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ def initialize(address1, address2) #:notnew:
1717
end
1818

1919
# Validates the parameters by checking if address1 and address2 are instances
20-
# of AddressParameter.
20+
# of AddressParameters or Strings.
2121
def validate_params
22-
a1_msg = 'address1 option can only be an instance of an AddressParameter'
23-
raise BadRequestError.new(a1_msg) if [AddressParameter].none? { |clazz| @address1.is_a? clazz }
22+
a1_msg = 'address1 option can only be an instance of an AddressParameter or a String'
23+
raise BadRequestError.new(a1_msg) if [String, AddressParameter].none? { |clazz| @address1.is_a? clazz }
2424

25-
a2_msg = 'address2 option can only be an instance of an AddressParameter'
26-
raise BadRequestError.new(a2_msg) if [AddressParameter].none? { |clazz| @address2.is_a? clazz }
25+
a2_msg = 'address2 option can only be an instance of an AddressParameter or a String'
26+
raise BadRequestError.new(a2_msg) if [String, AddressParameter].none? { |clazz| @address2.is_a? clazz }
2727
end
2828

2929
# Converts this class to Hash with its keys in lower CamelCase.

0 commit comments

Comments
 (0)