Cross platform chrome matching support (#133)

Co-authored-by: Aliaksandr Rasolka <[email protected]>

Author: iouym

WebDriverManager/DriverConfigs/Impl/ChromeConfig.cs

@@ -14,8 +14,6 @@ public class ChromeConfig : IDriverConfig
         private const string ExactReleaseVersionPatternUrl =
             "https://chromedriver.storage.googleapis.com/LATEST_RELEASE_<version>";
 
-        private const string BrowserExecutableFileName = "chrome.exe";
-
         public virtual string GetName()
         {
             return "Chrome";
@@ -78,10 +76,30 @@ private static string GetLatestVersion(string url)
 
         public virtual string GetMatchingBrowserVersion()
         {
-            var rawChromeBrowserVersion = RegistryHelper.GetInstalledBrowserVersion(BrowserExecutableFileName);
+            var rawChromeBrowserVersion = GetRawBrowserVersion();
             var chromeBrowserVersion = VersionHelper.GetVersionWithoutRevision(rawChromeBrowserVersion);
             var url = ExactReleaseVersionPatternUrl.Replace("<version>", chromeBrowserVersion);
             return GetLatestVersion(url);
         }
+
+        private string GetRawBrowserVersion()
+        {
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
+            {
+                return RegistryHelper.GetInstalledBrowserVersionOsx("Google Chrome", "--version");
+            }
+
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
+            {
+                return RegistryHelper.GetInstalledBrowserVersionLinux("google-chrome", "--product-version");
+            }
+
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                return RegistryHelper.GetInstalledBrowserVersionWin("chrome.exe");
+            }
+
+            throw new PlatformNotSupportedException("Your operating system is not supported");
+        }
     }
 }

WebDriverManager/DriverConfigs/Impl/EdgeConfig.cs

@@ -11,8 +11,6 @@ public class EdgeConfig : IDriverConfig
         private const string BaseVersionPatternUrl = "https://msedgedriver.azureedge.net/<version>/";
         private const string LatestReleaseVersionUrl = "https://msedgedriver.azureedge.net/LATEST_STABLE";
 
-        private const string BrowserExecutableFileName = "msedge.exe";
-
         public virtual string GetName()
         {
             return "Edge";
@@ -42,7 +40,7 @@ public virtual string GetLatestVersion()
             return GetLatestVersion(LatestReleaseVersionUrl);
         }
 
-        public virtual string GetLatestVersion(String url)
+        public virtual string GetLatestVersion(string url)
         {
             var uri = new Uri(url);
             var webRequest = WebRequest.Create(uri);
@@ -62,8 +60,17 @@ public virtual string GetLatestVersion(String url)
 
         public string GetMatchingBrowserVersion()
         {
-            var rawEdgeBrowserVersion = RegistryHelper.GetInstalledBrowserVersion(BrowserExecutableFileName);
-            return rawEdgeBrowserVersion;
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
+            {
+                return RegistryHelper.GetInstalledBrowserVersionOsx("Microsoft Edge", "--version");
+            }
+
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                return RegistryHelper.GetInstalledBrowserVersionWin("msedge.exe");
+            }
+
+            throw new PlatformNotSupportedException("Your operating system is not supported");
         }
     }
 }

WebDriverManager/Helpers/RegistryHelper.cs

@@ -1,22 +1,60 @@
+using System;
 using System.Diagnostics;
-using Microsoft.Win32;
+using System.Threading.Tasks;
 
 namespace WebDriverManager.Helpers
 {
     public static class RegistryHelper
     {
-        private const string CurrentUserRegistryPathPattern = @"HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\App Paths\<executableFileName>";
-        private const string LocalMachineRegistryPathPattern = @"HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\<executableFileName>";
+        public static string GetInstalledBrowserVersionLinux(string executableFileName, string arguments)
+        {
+            try
+            {
+                var outputVersion = Task.Run(() => VersionHelper.GetVersionFromProcess(executableFileName, arguments))
+                    .Result;
+                return outputVersion;
+            }
+            catch (Exception e)
+            {
+                throw new Exception(
+                    $"An error occured trying to locate installed browser version for runtime platform {Environment.OSVersion.Platform}",
+                    e);
+            }
+        }
+
+        public static string GetInstalledBrowserVersionOsx(string executableFileName, string arguments)
+        {
+            try
+            {
+                var executableFilePath = $"/Applications/{executableFileName}.app/Contents/MacOS/{executableFileName}";
+                var outputVersion = Task.Run(() => VersionHelper.GetVersionFromProcess(executableFilePath, arguments))
+                    .Result;
+                return outputVersion.Replace($"{executableFileName} ", "");
+            }
+            catch (Exception e)
+            {
+                throw new Exception(
+                    $"An error occured trying to locate installed browser version for runtime platform {Environment.OSVersion.Platform}",
+                    e);
+            }
+        }
 
-        public static string GetInstalledBrowserVersion(string executableFileName)
+        public static string GetInstalledBrowserVersionWin(string executableFileName)
         {
-            var currentUserPath = Registry.GetValue(CurrentUserRegistryPathPattern.Replace("<executableFileName>", executableFileName), "", null);
+            const string currentUserRegistryPathPattern =
+                @"HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\App Paths\<executableFileName>";
+            const string localMachineRegistryPathPattern =
+                @"HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\<executableFileName>";
+
+            var currentUserPath = Microsoft.Win32.Registry.GetValue(
+                currentUserRegistryPathPattern.Replace("<executableFileName>", executableFileName), "", null);
             if (currentUserPath != null)
             {
                 return FileVersionInfo.GetVersionInfo(currentUserPath.ToString()).FileVersion;
             }
 
-            var localMachinePath = Registry.GetValue(LocalMachineRegistryPathPattern.Replace("<executableFileName>", executableFileName), "", null);
+            var localMachinePath = Microsoft.Win32.Registry.GetValue(
+                localMachineRegistryPathPattern.Replace("<executableFileName>", executableFileName), "", null);
             if (localMachinePath != null)
             {
                 return FileVersionInfo.GetVersionInfo(localMachinePath.ToString()).FileVersion;

WebDriverManager/Helpers/VersionHelper.cs

@@ -1,18 +1,55 @@
 using System;
+using System.Diagnostics;
+using System.Threading.Tasks;
 
 namespace WebDriverManager.Helpers
 {
     public static class VersionHelper
     {
-        /*
-         * Returns a version number without the revision part.
-         *
-         * Example: 85.0.4183.83 -> 85.0.4183
-         */
+        /// <summary>
+        /// Returns a version number without the revision part.
+        /// Example: 85.0.4183.83 -> 85.0.4183
+        /// </summary>
+        /// <param name="version">Version to process</param>
+        /// <returns>Processed version</returns>
         public static string GetVersionWithoutRevision(string version)
         {
             var parsedVersion = Version.Parse(version);
             return $"{parsedVersion.Major}.{parsedVersion.Minor}.{parsedVersion.Build}";
         }
+
+        /// <summary>
+        /// Gets the current browser version on the executing system by running a process
+        /// </summary>
+        /// <param name="executableFileName">Browser executable file name</param>
+        /// <param name="arguments">Execution command line arguments</param>
+        /// <returns>Browser version received from browser started instance</returns>
+        public static async Task<string> GetVersionFromProcess(string executableFileName, string arguments)
+        {
+            var process = Process.Start(
+                new ProcessStartInfo
+                {
+                    FileName = executableFileName,
+                    Arguments = arguments,
+                    UseShellExecute = false,
+                    CreateNoWindow = true,
+                    RedirectStandardOutput = true,
+                    RedirectStandardError = true
+                }
+            );
+            if (process == null) throw new Exception("The process did not start");
+
+            var output = await process.StandardOutput.ReadToEndAsync();
+            var error = await process.StandardError.ReadToEndAsync();
+            process.WaitForExit();
+            process.Kill();
+
+            if (!string.IsNullOrEmpty(error))
+            {
+                throw new Exception(error);
+            }
+
+            return output;
+        }
     }
 }