Download chrome driver version matching with chrome browser version (#91)

tteguayco · web-flow · commit 0943c356319e · 2020-09-10T22:54:51.000+03:00
Closes #85
diff --git a/README.md b/README.md
@@ -104,6 +104,9 @@ Or architecture:
 Or version and architecture:
 	``new DriverManager().SetUpDriver(new ChromeConfig(), "2.25", Architecture.X64)``
 
+Only for Google Chrome so far, you can specify to automatically download a ```chromedriver.exe``` matching the version of the browser that is installed in your machine:
+    ``new DriverManager().SetUpDriver(new ChromeConfig(), VersionResolveStrategy.MatchingBrowser); ``
+
 #### Manual way:
 	new DriverManager().SetUpDriver(
                 "https://chromedriver.storage.googleapis.com/2.25/chromedriver_win32.zip", 
diff --git a/WebDriverManager.Tests/EdgeConfigTests.cs b/WebDriverManager.Tests/EdgeConfigTests.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Text.RegularExpressions;
 using WebDriverManager.DriverConfigs.Impl;
 using Xunit;
@@ -21,5 +22,11 @@ public void DriverDownloadTest()
             new DriverManager().SetUpDriver(new EdgeConfig());
             Assert.NotEmpty(WebDriverFinder.FindFile(GetBinaryName()));
         }
+
+        [Fact]
+        public void GetMatchingBrowserVersionTest()
+        {
+            Assert.Throws<NotImplementedException>(() => GetMatchingBrowserVersion());
+        }
     }
 }
diff --git a/WebDriverManager.Tests/FirefoxConfigTests.cs b/WebDriverManager.Tests/FirefoxConfigTests.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Text.RegularExpressions;
 using WebDriverManager.DriverConfigs.Impl;
 using Xunit;
@@ -21,5 +22,11 @@ public void DriverDownloadTest()
             new DriverManager().SetUpDriver(new FirefoxConfig());
             Assert.NotEmpty(WebDriverFinder.FindFile(GetBinaryName()));
         }
+
+        [Fact]
+        public void GetMatchingBrowserVersionTest()
+        {
+            Assert.Throws<NotImplementedException>(() => GetMatchingBrowserVersion());
+        }
     }
 }
diff --git a/WebDriverManager.Tests/InternetExplorerConfigTests.cs b/WebDriverManager.Tests/InternetExplorerConfigTests.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Text.RegularExpressions;
 using WebDriverManager.DriverConfigs.Impl;
 using Xunit;
@@ -21,5 +22,11 @@ public void DriverDownloadTest()
             new DriverManager().SetUpDriver(new InternetExplorerConfig());
             Assert.NotEmpty(WebDriverFinder.FindFile(GetBinaryName()));
         }
+
+        [Fact]
+        public void GetMatchingBrowserVersionTest()
+        {
+            Assert.Throws<NotImplementedException>(() => GetMatchingBrowserVersion());
+        }
     }
 }
diff --git a/WebDriverManager.Tests/LegacyEdgeConfigTests.cs b/WebDriverManager.Tests/LegacyEdgeConfigTests.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Text.RegularExpressions;
 using WebDriverManager.DriverConfigs.Impl;
 using Xunit;
@@ -21,5 +22,11 @@ public void DriverDownloadTest()
             new DriverManager().SetUpDriver(new LegacyEdgeConfig());
             Assert.NotEmpty(WebDriverFinder.FindFile(GetBinaryName()));
         }
+
+        [Fact]
+        public void GetMatchingBrowserVersionTest()
+        {
+            Assert.Throws<NotImplementedException>(() => GetMatchingBrowserVersion());
+        }
     }
 }
diff --git a/WebDriverManager.Tests/OperaConfigTests.cs b/WebDriverManager.Tests/OperaConfigTests.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Text.RegularExpressions;
 using WebDriverManager.DriverConfigs.Impl;
 using Xunit;
@@ -21,5 +22,11 @@ public void DriverDownloadTest()
             new DriverManager().SetUpDriver(new OperaConfig());
             Assert.NotEmpty(WebDriverFinder.FindFile(GetBinaryName()));
         }
+
+        [Fact]
+        public void GetMatchingBrowserVersionTest()
+        {
+            Assert.Throws<NotImplementedException>(() => GetMatchingBrowserVersion());
+        }
     }
 }
diff --git a/WebDriverManager.Tests/PhantomConfigTests.cs b/WebDriverManager.Tests/PhantomConfigTests.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Text.RegularExpressions;
 using WebDriverManager.DriverConfigs.Impl;
 using Xunit;
@@ -21,5 +22,11 @@ public void DriverDownloadTest()
             new DriverManager().SetUpDriver(new PhantomConfig());
             Assert.NotEmpty(WebDriverFinder.FindFile(GetBinaryName()));
         }
+
+        [Fact]
+        public void GetMatchingBrowserVersionTest()
+        {
+            Assert.Throws<NotImplementedException>(() => GetMatchingBrowserVersion());
+        }
     }
 }
diff --git a/WebDriverManager.sln b/WebDriverManager.sln
@@ -1,8 +1,11 @@
 ﻿
 Microsoft Visual Studio Solution File, Format Version 12.00
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WebDriverManager", "WebDriverManager\WebDriverManager.csproj", "{4AB1A17E-F75F-4A23-B986-7C3DE797B068}"
+# Visual Studio Version 16
+VisualStudioVersion = 16.0.30413.136
+MinimumVisualStudioVersion = 10.0.40219.1
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "WebDriverManager", "WebDriverManager\WebDriverManager.csproj", "{4AB1A17E-F75F-4A23-B986-7C3DE797B068}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WebDriverManager.Tests", "WebDriverManager.Tests\WebDriverManager.Tests.csproj", "{9C18F531-D338-4610-8CE7-697D7C7DE225}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "WebDriverManager.Tests", "WebDriverManager.Tests\WebDriverManager.Tests.csproj", "{9C18F531-D338-4610-8CE7-697D7C7DE225}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -19,4 +22,10 @@ Global
 		{9C18F531-D338-4610-8CE7-697D7C7DE225}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{9C18F531-D338-4610-8CE7-697D7C7DE225}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {9388057F-7595-485B-8564-77F96E217DE4}
+	EndGlobalSection
 EndGlobal
diff --git a/WebDriverManager/DriverConfigs/IDriverConfig.cs b/WebDriverManager/DriverConfigs/IDriverConfig.cs
@@ -1,4 +1,4 @@
-﻿namespace WebDriverManager.DriverConfigs
+namespace WebDriverManager.DriverConfigs
 {
     public interface IDriverConfig
     {
@@ -7,5 +7,6 @@ public interface IDriverConfig
         string GetUrl64();
         string GetBinaryName();
         string GetLatestVersion();
+        string GetMatchingBrowserVersion();
     }
 }
diff --git a/WebDriverManager/DriverConfigs/Impl/ChromeConfig.cs b/WebDriverManager/DriverConfigs/Impl/ChromeConfig.cs
@@ -1,13 +1,20 @@
-﻿using System;
+using System;
 using System.IO;
 using System.Net;
 using System.Runtime.InteropServices;
+using WebDriverManager.Helpers;
 
 namespace WebDriverManager.DriverConfigs.Impl
 {
     public class ChromeConfig : IDriverConfig
     {
         private const string BaseVersionPatternUrl = "https://chromedriver.storage.googleapis.com/<version>/";
+        private const string LatestReleaseVersionUrl = "https://chromedriver.storage.googleapis.com/LATEST_RELEASE";
+
+        private const string ExactReleaseVersionPatternUrl =
+            "https://chromedriver.storage.googleapis.com/LATEST_RELEASE_<version>";
+
+        private const string BrowserExecutableFileName = "chrome.exe";
 
         public virtual string GetName()
         {
@@ -48,7 +55,20 @@ public virtual string GetBinaryName()
 
         public virtual string GetLatestVersion()
         {
-            var uri = new Uri("https://chromedriver.storage.googleapis.com/LATEST_RELEASE");
+            return GetLatestVersion(LatestReleaseVersionUrl);
+        }
+
+        public virtual string GetMatchingBrowserVersion()
+        {
+            var rawChromeBrowserVersion = RegistryHelper.GetInstalledBrowserVersion(BrowserExecutableFileName);
+            var chromeBrowserVersion = VersionHelper.GetVersionWithoutRevision(rawChromeBrowserVersion);
+            var url = ExactReleaseVersionPatternUrl.Replace("<version>", chromeBrowserVersion);
+            return GetLatestVersion(url);
+        }
+
+        private static string GetLatestVersion(string url)
+        {
+            var uri = new Uri(url);
             var webRequest = WebRequest.Create(uri);
             using (var response = webRequest.GetResponse())
             {
diff --git a/WebDriverManager/DriverConfigs/Impl/EdgeConfig.cs b/WebDriverManager/DriverConfigs/Impl/EdgeConfig.cs
@@ -50,5 +50,10 @@ public virtual string GetLatestVersion()
                 }
             }
         }
+
+        public string GetMatchingBrowserVersion()
+        {
+            throw new NotImplementedException();
+        }
     }
 }
diff --git a/WebDriverManager/DriverConfigs/Impl/FirefoxConfig.cs b/WebDriverManager/DriverConfigs/Impl/FirefoxConfig.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Linq;
 using System.Net;
 using System.Runtime.InteropServices;
@@ -46,6 +47,11 @@ public virtual string GetLatestVersion()
             }
         }
 
+        public virtual string GetMatchingBrowserVersion()
+        {
+            throw new NotImplementedException();
+        }
+
         private static string GetUrl(Architecture architecture)
         {
             if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
diff --git a/WebDriverManager/DriverConfigs/Impl/InternetExplorerConfig.cs b/WebDriverManager/DriverConfigs/Impl/InternetExplorerConfig.cs
@@ -1,4 +1,6 @@
-﻿namespace WebDriverManager.DriverConfigs.Impl
+﻿using System;
+
+namespace WebDriverManager.DriverConfigs.Impl
 {
     public class InternetExplorerConfig : IDriverConfig
     {
@@ -26,5 +28,10 @@ public virtual string GetLatestVersion()
         {
             return "3.141.59";
         }
+
+        public virtual string GetMatchingBrowserVersion()
+        {
+            throw new NotImplementedException();
+        }
     }
 }
diff --git a/WebDriverManager/DriverConfigs/Impl/LegacyEdgeConfig.cs b/WebDriverManager/DriverConfigs/Impl/LegacyEdgeConfig.cs
@@ -1,3 +1,5 @@
+using System;
+
 namespace WebDriverManager.DriverConfigs.Impl
 {
     public class LegacyEdgeConfig : IDriverConfig
@@ -27,5 +29,10 @@ public virtual string GetLatestVersion()
         {
             return "6.17134";
         }
+
+        public virtual string GetMatchingBrowserVersion()
+        {
+            throw new NotImplementedException();
+        }
     }
 }
diff --git a/WebDriverManager/DriverConfigs/Impl/OperaConfig.cs b/WebDriverManager/DriverConfigs/Impl/OperaConfig.cs
@@ -1,4 +1,5 @@
-﻿using System.Linq;
+using System;
+using System.Linq;
 using System.Net;
 using AngleSharp.Html.Parser;
 
@@ -42,5 +43,10 @@ public virtual string GetLatestVersion()
                 return version;
             }
         }
+
+        public virtual string GetMatchingBrowserVersion()
+        {
+            throw new NotImplementedException();
+        }
     }
 }
diff --git a/WebDriverManager/DriverConfigs/Impl/PhantomConfig.cs b/WebDriverManager/DriverConfigs/Impl/PhantomConfig.cs
@@ -1,4 +1,6 @@
-﻿namespace WebDriverManager.DriverConfigs.Impl
+using System;
+
+namespace WebDriverManager.DriverConfigs.Impl
 {
     public class PhantomConfig : IDriverConfig
     {
@@ -26,5 +28,10 @@ public virtual string GetLatestVersion()
         {
             return "2.1.1";
         }
+
+        public virtual string GetMatchingBrowserVersion()
+        {
+            throw new NotImplementedException();
+        }
     }
 }
diff --git a/WebDriverManager/DriverManager.cs b/WebDriverManager/DriverManager.cs
@@ -1,4 +1,5 @@
-﻿using WebDriverManager.DriverConfigs;
+using System;
+using WebDriverManager.DriverConfigs;
 using WebDriverManager.Helpers;
 using WebDriverManager.Services;
 using WebDriverManager.Services.Impl;
@@ -7,7 +8,7 @@ namespace WebDriverManager
 {
     public class DriverManager
     {
-        static readonly object _object = new object();
+        private static readonly object Object = new object();
 
         private readonly IBinaryService _binaryService;
         private readonly IVariableService _variableService;
@@ -31,21 +32,31 @@ public void SetUpDriver(string url, string binaryPath, string binaryName)
             _variableService.SetupVariable(binaryPath);
         }
 
-        public void SetUpDriver(IDriverConfig config, string version = "Latest",
+        public void SetUpDriver(IDriverConfig config, string version = VersionResolveStrategy.Latest,
             Architecture architecture = Architecture.Auto)
         {
-            lock (_object)
+            lock (Object)
             {
                 architecture = architecture.Equals(Architecture.Auto)
                     ? ArchitectureHelper.GetArchitecture()
                     : architecture;
-                version = version.Equals("Latest") ? config.GetLatestVersion() : version;
+                version = GetVersionToDownload(config, version);
                 var url = architecture.Equals(Architecture.X32) ? config.GetUrl32() : config.GetUrl64();
                 url = UrlHelper.BuildUrl(url, version);
                 var binaryPath = FileHelper.GetBinDestination(config.GetName(), version, architecture,
                     config.GetBinaryName());
                 SetUpDriver(url, binaryPath, config.GetBinaryName());
             }
         }
+
+        private static string GetVersionToDownload(IDriverConfig config, string version)
+        {
+            switch (version)
+            {
+                case VersionResolveStrategy.MatchingBrowser: return config.GetMatchingBrowserVersion();
+                case VersionResolveStrategy.Latest: return config.GetLatestVersion();
+                default: return version;
+            }
+        }
     }
 }
diff --git a/WebDriverManager/Helpers/RegistryHelper.cs b/WebDriverManager/Helpers/RegistryHelper.cs
@@ -0,0 +1,31 @@
+using System;
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.Text;
+using Microsoft.Win32;
+
+namespace WebDriverManager.Helpers
+{
+    public static class RegistryHelper
+    {
+        private const string CurrentUserRegistryPathPattern = @"HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\App Paths\<executableFileName>";
+        private const string LocalMachineRegistryPathPattern = @"HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\<executableFileName>";
+
+        public static string GetInstalledBrowserVersion(string executableFileName)
+        {
+            var currentUserPath = Registry.GetValue(CurrentUserRegistryPathPattern.Replace("<executableFileName>", executableFileName), "", null);
+            if (currentUserPath != null)
+            {
+                return FileVersionInfo.GetVersionInfo(currentUserPath.ToString()).FileVersion;
+            }
+
+            var localMachinePath = Registry.GetValue(LocalMachineRegistryPathPattern.Replace("<executableFileName>", executableFileName), "", null);
+            if (localMachinePath != null)
+            {
+                return FileVersionInfo.GetVersionInfo(localMachinePath.ToString()).FileVersion;
+            }
+
+            return null;
+        }
+    }
+}
diff --git a/WebDriverManager/Helpers/VersionHelper.cs b/WebDriverManager/Helpers/VersionHelper.cs
@@ -0,0 +1,20 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace WebDriverManager.Helpers
+{
+    public static class VersionHelper
+    {
+        /*
+         * Returns a version number without the revision part.
+         *
+         * Example: 85.0.4183.83 -> 85.0.4183
+         */
+        public static string GetVersionWithoutRevision(string version)
+        {
+            var parsedVersion = Version.Parse(version);
+            return $"{parsedVersion.Major}.{parsedVersion.Minor}.{parsedVersion.Build}";
+        }
+    }
+}
diff --git a/WebDriverManager/Helpers/VersionResolveStrategy.cs b/WebDriverManager/Helpers/VersionResolveStrategy.cs
diff --git a/WebDriverManager/WebDriverManager.csproj b/WebDriverManager/WebDriverManager.csproj

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+using System;`
`1`	`2`	`using System.Text.RegularExpressions;`
`2`	`3`	`using WebDriverManager.DriverConfigs.Impl;`
`3`	`4`	`using Xunit;`
`@@ -21,5 +22,11 @@ public void DriverDownloadTest()`
`21`	`22`	`new DriverManager().SetUpDriver(new EdgeConfig());`
`22`	`23`	`Assert.NotEmpty(WebDriverFinder.FindFile(GetBinaryName()));`
`23`	`24`	`}`
	`25`	`+`
	`26`	`+ [Fact]`
	`27`	`+ public void GetMatchingBrowserVersionTest()`
	`28`	`+ {`
	`29`	`+ Assert.Throws<NotImplementedException>(() => GetMatchingBrowserVersion());`
	`30`	`+ }`
`24`	`31`	`}`
`25`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-namespace WebDriverManager.DriverConfigs`
	`1`	`+namespace WebDriverManager.DriverConfigs`
`2`	`2`	`{`
`3`	`3`	`public interface IDriverConfig`
`4`	`4`	`{`
`@@ -7,5 +7,6 @@ public interface IDriverConfig`
`7`	`7`	`string GetUrl64();`
`8`	`8`	`string GetBinaryName();`
`9`	`9`	`string GetLatestVersion();`
	`10`	`+ string GetMatchingBrowserVersion();`
`10`	`11`	`}`
`11`	`12`	`}`