Skip to content

Commit 521f54c

Browse files
committed
Add ability to override methods for default driver configs.
Update readme
1 parent 78e4b1b commit 521f54c

File tree

7 files changed

+34
-34
lines changed

7 files changed

+34
-34
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,12 +182,12 @@ Or version and architecture:
182182
### Or you can modify existed drivers and change only necessary fields(same example):
183183
public class TaobaoPhantomConfig : PhantomConfig
184184
{
185-
public string GetName()
185+
public override string GetName()
186186
{
187187
return "TaobaoPhantom";
188188
}
189189

190-
public string GetUrl32()
190+
public override string GetUrl32()
191191
{
192192
return "https://npm.taobao.org/mirrors/phantomjs/phantomjs-<version>-windows.zip";
193193
}
@@ -202,7 +202,7 @@ Thanks to the following companies for generously providing their services/produc
202202

203203
Logo | Description
204204
------------ | -------------
205-
![BrowserStack](https://cdn.rawgit.com/rosolko/5df6447289fb4f40f14311d0275e7869/raw/01758b5090bf6a95710d703891692567234bfc25/browserstack.svg) | [BrowserStack](https://www.browserstack.com) is a cloud-based cross-browser testing tool that enables developers to test their websites across various browsers on different operating systems and mobile devices, without requiring users to install virtual machines, devices or emulators.
205+
![BrowserStack](https://cdn.rawgit.com/rosolko/5df6447289fb4f40f14311d0275e7869/raw/01758b5090bf6a95710d703891692567234bfc25/browserstack.svg) | [BrowserStack](https://www.browserstack.com) is a cloud-based cross-browser testing tool that enables developers to test their websites across various browsers on different operating systems and mobile devices, without requiring users to install virtual machines, devices or emulators.
206206
![GitHub](https://cdn.rawgit.com/rosolko/3ab6cb55f21009a2bc8eb1749170958e/raw/bf0cf26772bea67340c4a600b5339b25839e0696/github.svg) | [GitHub](https://github.com) is a web-based Git repository hosting service. It offers all of the distributed version control and source code management (SCM) functionality of Git as well as adding several collaboration features such as bug tracking, feature requests, task management, and wikis for every project.
207207
![AppVeyor](https://cdn.rawgit.com/rosolko/97d00e90fa68763bbd28462b17bda903/raw/71a23a11b4efdafbc31356e19cbbb1c155ff62fb/appveyor.svg) | [AppVeyor](https://appveyor.com) is a hosted, distributed continuous integration service used to build and test projects hosted at GitHub on a Microsoft Windows virtual machine.
208208

WebDriverManager/DriverConfigs/Impl/ChromeConfig.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,27 @@ namespace WebDriverManager.DriverConfigs.Impl
66
{
77
public class ChromeConfig : IDriverConfig
88
{
9-
public string GetName()
9+
public virtual string GetName()
1010
{
1111
return "Chrome";
1212
}
1313

14-
public string GetUrl32()
14+
public virtual string GetUrl32()
1515
{
1616
return "https://chromedriver.storage.googleapis.com/<version>/chromedriver_win32.zip";
1717
}
1818

19-
public string GetUrl64()
19+
public virtual string GetUrl64()
2020
{
2121
return GetUrl32();
2222
}
2323

24-
public string GetBinaryName()
24+
public virtual string GetBinaryName()
2525
{
2626
return "chromedriver.exe";
2727
}
2828

29-
public string GetLatestVersion()
29+
public virtual string GetLatestVersion()
3030
{
3131
const string url = @"https://chromedriver.storage.googleapis.com/LATEST_RELEASE";
3232
var webRequest = WebRequest.Create(url);

WebDriverManager/DriverConfigs/Impl/EdgeConfig.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,27 @@ namespace WebDriverManager.DriverConfigs.Impl
77
{
88
public class EdgeConfig : IDriverConfig
99
{
10-
public string GetName()
10+
public virtual string GetName()
1111
{
1212
return "Edge";
1313
}
1414

15-
public string GetUrl32()
15+
public virtual string GetUrl32()
1616
{
1717
return GetUrl();
1818
}
1919

20-
public string GetUrl64()
20+
public virtual string GetUrl64()
2121
{
2222
return GetUrl32();
2323
}
2424

25-
public string GetBinaryName()
25+
public virtual string GetBinaryName()
2626
{
2727
return "MicrosoftWebDriver.exe";
2828
}
2929

30-
public string GetLatestVersion()
30+
public virtual string GetLatestVersion()
3131
{
3232
using (var client = new WebClient())
3333
{
@@ -43,7 +43,7 @@ public string GetLatestVersion()
4343
}
4444
}
4545

46-
private static string GetUrl()
46+
public virtual string GetUrl()
4747
{
4848
using (var client = new WebClient())
4949
{

WebDriverManager/DriverConfigs/Impl/FirefoxConfig.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,27 @@ namespace WebDriverManager.DriverConfigs.Impl
77
{
88
public class FirefoxConfig : IDriverConfig
99
{
10-
public string GetName()
10+
public virtual string GetName()
1111
{
1212
return "Firefox";
1313
}
1414

15-
public string GetUrl32()
15+
public virtual string GetUrl32()
1616
{
1717
return GetUrl64();
1818
}
1919

20-
public string GetUrl64()
20+
public virtual string GetUrl64()
2121
{
2222
return "https://github.com/mozilla/geckodriver/releases/download/v<version>/geckodriver-v<version>-win64.zip";
2323
}
2424

25-
public string GetBinaryName()
25+
public virtual string GetBinaryName()
2626
{
2727
return "geckodriver.exe";
2828
}
2929

30-
public string GetLatestVersion()
30+
public virtual string GetLatestVersion()
3131
{
3232
using (var client = new WebClient())
3333
{

WebDriverManager/DriverConfigs/Impl/InternetExplorerConfig.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,27 @@ namespace WebDriverManager.DriverConfigs.Impl
88
{
99
public class InternetExplorerConfig : IDriverConfig
1010
{
11-
public string GetName()
11+
public virtual string GetName()
1212
{
1313
return "InternetExplorer";
1414
}
1515

16-
public string GetUrl32()
16+
public virtual string GetUrl32()
1717
{
1818
return "http://selenium-release.storage.googleapis.com/<release>/IEDriverServer_Win32_<version>.zip";
1919
}
2020

21-
public string GetUrl64()
21+
public virtual string GetUrl64()
2222
{
2323
return "http://selenium-release.storage.googleapis.com/<release>/IEDriverServer_x64_<version>.zip";
2424
}
2525

26-
public string GetBinaryName()
26+
public virtual string GetBinaryName()
2727
{
2828
return "IEDriverServer.exe";
2929
}
3030

31-
public string GetLatestVersion()
31+
public virtual string GetLatestVersion()
3232
{
3333
var regex = new Regex(@"^\d+\.\d+\.\d+$");
3434
using (var client = new WebClient())

WebDriverManager/DriverConfigs/Impl/OperaConfig.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,27 @@ namespace WebDriverManager.DriverConfigs.Impl
77
{
88
public class OperaConfig : IDriverConfig
99
{
10-
public string GetName()
10+
public virtual string GetName()
1111
{
1212
return "Opera";
1313
}
1414

15-
public string GetUrl32()
15+
public virtual string GetUrl32()
1616
{
1717
return "https://github.com/operasoftware/operachromiumdriver/releases/download/v<version>/operadriver_win32.zip";
1818
}
1919

20-
public string GetUrl64()
20+
public virtual string GetUrl64()
2121
{
2222
return "https://github.com/operasoftware/operachromiumdriver/releases/download/v<version>/operadriver_win64.zip";
2323
}
2424

25-
public string GetBinaryName()
25+
public virtual string GetBinaryName()
2626
{
2727
return "operadriver.exe";
2828
}
2929

30-
public string GetLatestVersion()
30+
public virtual string GetLatestVersion()
3131
{
3232
using (var client = new WebClient())
3333
{

WebDriverManager/DriverConfigs/Impl/PhantomConfig.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,27 @@ namespace WebDriverManager.DriverConfigs.Impl
77
{
88
public class PhantomConfig : IDriverConfig
99
{
10-
public string GetName()
10+
public virtual string GetName()
1111
{
1212
return "Phantom";
1313
}
1414

15-
public string GetUrl32()
15+
public virtual string GetUrl32()
1616
{
1717
return "https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-<version>-windows.zip";
1818
}
1919

20-
public string GetUrl64()
20+
public virtual string GetUrl64()
2121
{
2222
return GetUrl32();
2323
}
2424

25-
public string GetBinaryName()
25+
public virtual string GetBinaryName()
2626
{
2727
return "phantomjs.exe";
2828
}
2929

30-
public string GetLatestVersion()
30+
public virtual string GetLatestVersion()
3131
{
3232
using (var client = new WebClient())
3333
{

0 commit comments

Comments
 (0)