Fix issues #2 #3 #4

Author: rosolko

WebDriverManager/BrowserManagers/ChromeDriverManager.cs

@@ -62,7 +62,8 @@ public ChromeDriverManager(string version)
 
         public void Init()
         {
-            _config.Destination = Path.Combine(Directory.GetCurrentDirectory(), WebDriverManagerConfig.DefaultDestinationFolder);
+            _config.Destination = Path.Combine(Directory.GetCurrentDirectory(),
+                WebDriverManagerConfig.DefaultDestinationFolder);
             Log?.Debug($"Use default chrome driver destination path: '{_config.Destination}'");
             Base();
         }

WebDriverManager/Helpers/WebDriverManager.cs

@@ -1,4 +1,6 @@
-namespace WebDriverManager.Helpers
+using Microsoft.Win32;
+
+namespace WebDriverManager.Helpers
 {
     using NLog;
     using System;
@@ -173,7 +175,7 @@ public static void AddEnvironmentVariable(string variable)
             {
                 var variableValue = Environment.GetEnvironmentVariable(variable);
                 if (variableValue == null || !variableValue.Equals(DestinationFolder))
-                    Environment.SetEnvironmentVariable(variable, DestinationFolder, EnvironmentVariableTarget.Machine);
+                    Environment.SetEnvironmentVariable(variable, DestinationFolder, EnvironmentVariableTarget.Process);
             }
             catch (Exception ex)
             {
@@ -187,20 +189,18 @@ public static void AddEnvironmentVariable(string variable)
         /// Update browser driver environment variable if it's already exist and different from current
         /// </summary>
         /// <param name="variable">Environment variable</param>
-        /// <param name="extendPath">Extend PATH variable with driver variable</param>
-        public static void UpdatePath(string variable, bool extendPath = false)
+        public static void UpdatePath(string variable)
         {
             try
             {
-                if (!extendPath) return;
                 const string name = "PATH";
-                var pathVariable = Environment.GetEnvironmentVariable(name);
-                var newPathVariable = pathVariable +
-                                      (pathVariable != null && pathVariable.EndsWith(";") ? string.Empty : ";") +
-                                      $@"%{variable}%";
-                if (pathVariable != null && !pathVariable.Contains(DestinationFolder) &&
-                    !pathVariable.Contains(variable))
-                    Environment.SetEnvironmentVariable(newPathVariable, name, EnvironmentVariableTarget.Machine);
+                const string keyName = @"SYSTEM\CurrentControlSet\Control\Session Manager\Environment";
+                var pathVariable = (string) Registry.LocalMachine.CreateSubKey(keyName)?
+                    .GetValue(name, string.Empty, RegistryValueOptions.DoNotExpandEnvironmentNames);
+                if (pathVariable == null) throw new Exception($"Can't get {name} variable");
+                var newPathVariable = $"%{variable}%;{pathVariable}";
+                if (!pathVariable.Contains(variable))
+                    Environment.SetEnvironmentVariable(name, newPathVariable, EnvironmentVariableTarget.Process);
             }
             catch (Exception ex)
             {

WebDriverManager/Properties/AssemblyInfo.cs

@@ -39,5 +39,5 @@
 // by using the '*' as shown below:
 //[assembly: AssemblyVersion("1.0.*")]
 
-[assembly: AssemblyVersion("1.2.3")]
-[assembly: AssemblyFileVersion("1.2.3")]
+[assembly: AssemblyVersion("1.3.0")]
+[assembly: AssemblyFileVersion("1.3.0")]

WebDriverManager/WebDriverManager.nuspec

@@ -11,7 +11,7 @@
     <requireLicenseAcceptance>false</requireLicenseAcceptance>
     <description>$description$</description>
     <summary>$description$</summary>
-    <releaseNotes>Fix issue #3 and typos</releaseNotes>
+    <releaseNotes>Fix issues #2 #3 #4</releaseNotes>
     <copyright>Copyright © Alexander Rosolko 2016</copyright>
     <tags>Selenium WebDriver ChromeDriver EdgeDriver InternetExplorerDriver MarionetteDriver OperaDriver PhantomJsDriver AppiumDriver</tags>
   </metadata>

qube.bat

@@ -1,3 +1,3 @@
-MSBuild.SonarQube.Runner.exe begin /k:"rosolko" /n:"WebDriverManager.Net" /v:"1.2.1"
+MSBuild.SonarQube.Runner.exe begin /k:"rosolko" /n:"WebDriverManager.Net" /v:"1.3.0"
 msbuild /t:Rebuild
 MSBuild.SonarQube.Runner.exe end