Lock full SetUpDriver method not only unzip. Fix dge driver name on mac os.

Author: rosolko

WebDriverManager.Tests/DriverManagerTests.cs

@@ -0,0 +1,24 @@
+using WebDriverManager.DriverConfigs.Impl;
+using Xunit;
+
+[assembly: CollectionBehavior(CollectionBehavior.CollectionPerClass, MaxParallelThreads = 2)]
+namespace WebDriverManager.Tests
+{
+    public class DriverManagerTests
+    {
+        [Fact]
+        public void ChromeTest()
+        {
+            new DriverManager().SetUpDriver(new ChromeConfig());
+        }
+    }
+
+    public class ParallelDriverManagerTests
+    {
+        [Fact]
+        public void ParallelChromeTest()
+        {
+            new DriverManager().SetUpDriver(new ChromeConfig());
+        }
+    }
+}

WebDriverManager/DriverConfigs/Impl/EdgeConfig.cs

@@ -28,7 +28,9 @@ public virtual string GetUrl64()
 
         public virtual string GetBinaryName()
         {
-            return "msedgedriver.exe";
+            return RuntimeInformation.IsOSPlatform(OSPlatform.OSX)
+                ? "msedgedriver.exe"
+                : "msedgedriver";
         }
 
         public virtual string GetLatestVersion()

WebDriverManager/DriverManager.cs

@@ -7,6 +7,8 @@ namespace WebDriverManager
 {
     public class DriverManager
     {
+        static readonly object _object = new object();
+
         private readonly IBinaryService _binaryService;
         private readonly IVariableService _variableService;
 
@@ -32,13 +34,18 @@ public void SetUpDriver(string url, string binaryPath, string binaryName)
         public void SetUpDriver(IDriverConfig config, string version = "Latest",
             Architecture architecture = Architecture.Auto)
         {
-            architecture = architecture.Equals(Architecture.Auto) ? ArchitectureHelper.GetArchitecture() : architecture;
-            version = version.Equals("Latest") ? config.GetLatestVersion() : version;
-            var url = architecture.Equals(Architecture.X32) ? config.GetUrl32() : config.GetUrl64();
-            url = UrlHelper.BuildUrl(url, version);
-            var binaryPath = FileHelper.GetBinDestination(config.GetName(), version, architecture,
-                config.GetBinaryName());
-            SetUpDriver(url, binaryPath, config.GetBinaryName());
+            lock (_object)
+            {
+                architecture = architecture.Equals(Architecture.Auto)
+                    ? ArchitectureHelper.GetArchitecture()
+                    : architecture;
+                version = version.Equals("Latest") ? config.GetLatestVersion() : version;
+                var url = architecture.Equals(Architecture.X32) ? config.GetUrl32() : config.GetUrl64();
+                url = UrlHelper.BuildUrl(url, version);
+                var binaryPath = FileHelper.GetBinDestination(config.GetName(), version, architecture,
+                    config.GetBinaryName());
+                SetUpDriver(url, binaryPath, config.GetBinaryName());
+            }
         }
     }
 }

WebDriverManager/Services/Impl/BinaryService.cs

@@ -10,8 +10,6 @@ namespace WebDriverManager.Services.Impl
 {
     public class BinaryService : IBinaryService
     {
-        static readonly object _object = new object();
-
         public string SetupBinary(string url, string zipDestination, string binDestination, string binaryName)
         {
             if (File.Exists(binDestination)) return binDestination;
@@ -52,28 +50,25 @@ protected string DownloadZip(string url, string destination)
 
         protected string UnZip(string path, string destination, string name)
         {
-            lock (_object)
+            var zipName = Path.GetFileName(path);
+            if (zipName != null && zipName.Equals(name, StringComparison.CurrentCultureIgnoreCase))
             {
-                var zipName = Path.GetFileName(path);
-                if (zipName != null && zipName.Equals(name, StringComparison.CurrentCultureIgnoreCase))
-                {
-                    File.Copy(path, destination);
-                    return destination;
-                }
+                File.Copy(path, destination);
+                return destination;
+            }
 
-                using (var zip = ZipFile.Open(path, ZipArchiveMode.Read))
+            using (var zip = ZipFile.Open(path, ZipArchiveMode.Read))
+            {
+                foreach (var entry in zip.Entries)
                 {
-                    foreach (var entry in zip.Entries)
+                    if (entry.Name == name)
                     {
-                        if (entry.Name == name)
-                        {
-                            entry.ExtractToFile(destination, true);
-                        }
+                        entry.ExtractToFile(destination, true);
                     }
                 }
-
-                return destination;
             }
+
+            return destination;
         }
 
         protected void RemoveZip(string path)