Skip to content

Commit a4c5daf

Browse files
committed
Try to fix browser tests(for some reason browser isn't close)
1 parent 4ed7760 commit a4c5daf

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

IntegrationTests/BrowserTests/BrowserTests.cs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ public class BrowserData : IEnumerable<object[]>
1414
{
1515
private readonly List<object[]> _data = new List<object[]>
1616
{
17-
new object[] {new ChromeConfig(), DriverType.Chrome, "chromedriver"},
18-
// new object[] {new EdgeConfig(), DriverType.Edge, "MicrosoftWebDriver"},
19-
new object[] {new FirefoxConfig(), DriverType.Firefox, "geckodriver"},
20-
new object[] {new InternetExplorerConfig(), DriverType.InternetExplorer, "IEDriverServer"},
21-
new object[] {new OperaConfig(), DriverType.Opera, "operadriver"},
22-
new object[] {new PhantomConfig(), DriverType.Phantom, "phantomjs"}
17+
new object[] {new ChromeConfig(), DriverType.Chrome, "chromedriver", "chrome"},
18+
// new object[] {new EdgeConfig(), DriverType.Edge, "MicrosoftWebDriver", "MicrosoftEdge"},
19+
new object[] {new FirefoxConfig(), DriverType.Firefox, "geckodriver", "firefox"},
20+
new object[] {new InternetExplorerConfig(), DriverType.InternetExplorer, "IEDriverServer", "iexplore"},
21+
new object[] {new OperaConfig(), DriverType.Opera, "operadriver", "opera"},
22+
new object[] {new PhantomConfig(), DriverType.Phantom, "phantomjs", "phantomjs"}
2323
};
2424

2525
public IEnumerator<object[]> GetEnumerator()
@@ -37,11 +37,13 @@ public class BrowserTests : IDisposable
3737
{
3838
private IWebDriver _webDriver;
3939
private string _driverExe;
40+
private string _browserExe;
4041

4142
[Theory, ClassData(typeof(BrowserData)), Trait("Category", "Browser")]
42-
protected void BrowserTest(IDriverConfig driverConfig, DriverType driverType, string driverExe)
43+
protected void BrowserTest(IDriverConfig driverConfig, DriverType driverType, string driverExe, string browserExe)
4344
{
4445
_driverExe = driverExe;
46+
_browserExe = browserExe;
4547
new DriverManager().SetUpDriver(driverConfig);
4648
_webDriver = new DriverCreator().Create(driverType);
4749
_webDriver.Navigate().GoToUrl("https://www.wikipedia.org");
@@ -61,6 +63,7 @@ public void Dispose()
6163
finally
6264
{
6365
Helper.KillProcesses(_driverExe);
66+
Helper.KillProcesses(_browserExe);
6467
}
6568
}
6669
}

IntegrationTests/BrowserTests/Helper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ public static class Helper
77
{
88
public static void KillProcesses(string driverExe)
99
{
10-
Thread.Sleep(1500);
10+
Thread.Sleep(1000);
1111
var driverProcesses = Process.GetProcessesByName(driverExe);
1212
foreach (var driverProcess in driverProcesses)
1313
{

0 commit comments

Comments
 (0)