Skip to content

Commit e6176bb

Browse files
committed
Add coverage badge.
Refactor chrome config.
1 parent 031de98 commit e6176bb

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
[![Build status](https://ci.appveyor.com/api/projects/status/kjpqb5twmpxw6lpl?svg=true)](https://ci.appveyor.com/project/rosolko/webdrivermanager-net)
22
[![Quality Gate](https://sonarcloud.io/api/project_badges/measure?project=webdrivermanager.net&metric=alert_status)](https://sonarcloud.io/dashboard?id=webdrivermanager.net)
3+
[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=webdrivermanager.net&metric=coverage)](https://sonarcloud.io/dashboard?id=webdrivermanager.net)
34
[![NuGet](https://img.shields.io/nuget/v/WebDriverManager.svg)](https://www.nuget.org/packages/WebDriverManager)
45

56
# WebDriverManager.Net

WebDriverManager/DriverConfigs/Impl/ChromeConfig.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,13 @@ public virtual string GetBinaryName()
2828

2929
public virtual string GetLatestVersion()
3030
{
31-
var webRequest = WebRequest.Create("https://chromedriver.storage.googleapis.com/LATEST_RELEASE");
31+
var uri = new Uri("https://chromedriver.storage.googleapis.com/LATEST_RELEASE");
32+
var webRequest = WebRequest.Create(uri);
3233
using (var response = webRequest.GetResponse())
3334
{
3435
using (var content = response.GetResponseStream())
3536
{
36-
if (content == null) throw new Exception("Unable to get latest chrome version");
37+
if (content == null) throw new ArgumentNullException($"Can't get content from URL: {uri}");
3738
using (var reader = new StreamReader(content))
3839
{
3940
var version = reader.ReadToEnd().Trim();

0 commit comments

Comments
 (0)