SonarQube Code Reduction

Composer Update
SonarQube Code Reduction

Author: rossaddison

angular/src/app/invoice-amount-magnifier.js

@@ -38,9 +38,9 @@ class InvoiceAmountMagnifier {
       elements.forEach((element: Element) => {
         const htmlElement = element as HTMLElement;
 
-        if (this.isAmountElement(htmlElement) && !htmlElement.hasAttribute('data-magnifier-initialized')) {
+        if (this.isAmountElement(htmlElement) && !htmlElement.dataset.magnifierInitialized) {
           this.addMagnificationBehavior(htmlElement);
-          htmlElement.setAttribute('data-magnifier-initialized', 'true');
+          htmlElement.dataset.magnifierInitialized = 'true';
         }
       });
     });
@@ -70,17 +70,18 @@ class InvoiceAmountMagnifier {
     }
 
     // Store original styles
+    const computedStyle = globalThis.getComputedStyle(element);
     const originalStyles = {
-      fontSize: window.getComputedStyle(element).fontSize,
-      fontWeight: window.getComputedStyle(element).fontWeight,
-      backgroundColor: window.getComputedStyle(element).backgroundColor,
-      border: window.getComputedStyle(element).border,
-      borderRadius: window.getComputedStyle(element).borderRadius,
-      padding: window.getComputedStyle(element).padding,
-      zIndex: window.getComputedStyle(element).zIndex,
-      position: window.getComputedStyle(element).position,
-      transform: window.getComputedStyle(element).transform,
-      boxShadow: window.getComputedStyle(element).boxShadow
+      fontSize:        computedStyle.fontSize,
+      fontWeight:      computedStyle.fontWeight,
+      backgroundColor: computedStyle.backgroundColor,
+      border:          computedStyle.border,
+      borderRadius:    computedStyle.borderRadius,
+      padding:         computedStyle.padding,
+      zIndex:          computedStyle.zIndex,
+      position:        computedStyle.position,
+      transform:       computedStyle.transform,
+      boxShadow:       computedStyle.boxShadow
     };
 
     // Set base styles
@@ -172,6 +173,4 @@ class InvoiceAmountMagnifier {
 const invoiceAmountMagnifier = new InvoiceAmountMagnifier();
 
 // Export for manual control if needed
-if (typeof window !== 'undefined') {
-  (window as any).InvoiceAmountMagnifier = InvoiceAmountMagnifier;
-}
+(globalThis as any).InvoiceAmountMagnifier = InvoiceAmountMagnifier;

angular/src/app/invoice-amount-magnifier.service.ts

@@ -46,9 +46,9 @@ export class InvoiceAmountMagnifierService implements OnDestroy {
       elements.forEach((element: Element) => {
         const htmlElement = element as HTMLElement;
 
-        if (this.isAmountElement(htmlElement) && !htmlElement.hasAttribute('data-magnifier-initialized')) {
+        if (this.isAmountElement(htmlElement) && !htmlElement.dataset.magnifierInitialized) {
           this.addMagnificationBehavior(htmlElement);
-          htmlElement.setAttribute('data-magnifier-initialized', 'true');
+          htmlElement.dataset.magnifierInitialized = 'true';
         }
       });
     });
@@ -78,7 +78,7 @@ export class InvoiceAmountMagnifierService implements OnDestroy {
     }
 
     // Store original styles
-    const computedStyle = window.getComputedStyle(element);
+    const computedStyle = globalThis.getComputedStyle(element);
     const originalStyles = {
       fontSize: computedStyle.fontSize,
       fontWeight: computedStyle.fontWeight,

angular/src/app/invoice-amounts.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit, OnDestroy, AfterViewInit } from '@angular/core';
+import { Component, AfterViewInit } from '@angular/core';
 import { InvoiceAmountMagnifierService } from './invoice-amount-magnifier.service';
 
 @Component({
@@ -40,22 +40,14 @@ import { InvoiceAmountMagnifierService } from './invoice-amount-magnifier.servic
     }
   `]
 })
-export class InvoiceAmountsComponent implements OnInit, OnDestroy, AfterViewInit {
+export class InvoiceAmountsComponent implements AfterViewInit {
 
   constructor(private magnifierService: InvoiceAmountMagnifierService) {}
 
-  ngOnInit() {
-    // Service automatically initializes
-  }
-
   ngAfterViewInit() {
     // Reinitialize after view is ready
     setTimeout(() => {
       this.magnifierService.reinitialize();
     }, 200);
   }
-
-  ngOnDestroy() {
-    // Service handles its own cleanup
-  }
 }

angular/src/app/services/flash-message.service.ts

@@ -145,13 +145,13 @@ export class FlashMessageService {
    */
   private getFlashTimer(): any {
     // Try to get from window first
-    if (window.flashMessageTimer) {
-      return window.flashMessageTimer;
+    if (globalThis.flashMessageTimer) {
+      return globalThis.flashMessageTimer;
     }
 
     // Try to find in DOM through window object
-    if ((window as any).flashMessageTimerInstance) {
-      return (window as any).flashMessageTimerInstance;
+    if ((globalThis as any).flashMessageTimerInstance) {
+      return (globalThis as any).flashMessageTimerInstance;
     }
 
     return null;

angular/src/main.ts

@@ -1,8 +1,12 @@
 import { bootstrapApplication } from '@angular/platform-browser';
 import { AppComponent } from './app/app.component';
 
-bootstrapApplication(AppComponent, {
-  providers: [
-    // Add any global providers here
-  ]
-}).catch(err => console.error(err));
+try {
+  await bootstrapApplication(AppComponent, {
+    providers: [
+      // Add any global providers here
+    ]
+  });
+} catch (err) {
+  console.error(err);
+}

composer.json

@@ -147,14 +147,14 @@
     },    
     "require-dev": {
         "codeception/c3": "^2.9",
-        "codeception/codeception": "^5.3.4",
+        "codeception/codeception": "^5.3.5",
         "codeception/module-asserts": "^3.3.0",
         "codeception/module-cli": "^2.0.1",
         "codeception/module-phpbrowser": "^4.0.0",
-        "friendsofphp/php-cs-fixer": "^3.94.0",
+        "friendsofphp/php-cs-fixer": "^3.94.1",
         "guzzlehttp/promises": ">=2.3",
-        "phpunit/phpunit": "^12.5.12",
-        "rector/rector": "^2.3.6",
+        "phpunit/phpunit": "^12.5.14",
+        "rector/rector": "^2.3.7",
         "roave/better-reflection": "^6.69",
         "roave/infection-static-analysis-plugin": ">=1.43",
         "roave/security-advisories": "dev-latest",