fix: avoid panicking if serverRecoveryWindow has still not been set (cloudnative-pg#525)

leonardoce · web-flow · commit 5612fad13590 · 2025-09-18T15:28:53.000+02:00
Closes: cloudnative-pg#523 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
diff --git a/internal/cnpgi/instance/recovery_window.go b/internal/cnpgi/instance/recovery_window.go
@@ -59,7 +59,12 @@ func setLastFailedBackupTime(
 		}
 		recoveryWindow := objectStore.Status.ServerRecoveryWindow[serverName]
 		recoveryWindow.LastFailedBackupTime = ptr.To(metav1.NewTime(lastFailedBackupTime))
+
+		if objectStore.Status.ServerRecoveryWindow == nil {
+			objectStore.Status.ServerRecoveryWindow = make(map[string]barmancloudv1.RecoveryWindow)
+		}
 		objectStore.Status.ServerRecoveryWindow[serverName] = recoveryWindow
+
 		return c.Status().Update(ctx, &objectStore)
 	})
 }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,12 @@ func setLastFailedBackupTime(`
`59`	`59`	`}`
`60`	`60`	`recoveryWindow := objectStore.Status.ServerRecoveryWindow[serverName]`
`61`	`61`	`recoveryWindow.LastFailedBackupTime = ptr.To(metav1.NewTime(lastFailedBackupTime))`
	`62`	`+`
	`63`	`+ if objectStore.Status.ServerRecoveryWindow == nil {`
	`64`	`+ objectStore.Status.ServerRecoveryWindow = make(map[string]barmancloudv1.RecoveryWindow)`
	`65`	`+ }`
`62`	`66`	`objectStore.Status.ServerRecoveryWindow[serverName] = recoveryWindow`
	`67`	`+`
`63`	`68`	`return c.Status().Update(ctx, &objectStore)`
`64`	`69`	`})`
`65`	`70`	`}`