Fix clippy lints

Author: rossmacarthur

Cargo.toml

@@ -1,6 +1,13 @@
 [workspace]
 members = ["crates/*"]
 
+[workspace.lints.rust]
+elided-lifetimes-in-paths = "warn"
+unsafe_op_in_unsafe_fn = "warn"
+
+[workspace.lints.clippy]
+needless_borrow = "allow"
+
 [workspace.package]
 version = "0.3.0"
 authors = ["Ross MacArthur <ross@macarthur.io>"]
@@ -37,6 +44,9 @@ default = ["macro", "std"]
 std = []
 macro = ["dep:vectrix-macro"]
 
+[lints]
+workspace = true
+
 [[bench]]
 name = "euler"
 harness = false

clippy.toml

@@ -0,0 +1 @@
+msrv = "1.87"

crates/macro/Cargo.toml

@@ -16,3 +16,6 @@ proc-macro = true
 proc-macro2 = "1.0"
 quote = "1.0"
 syn = "2.0"
+
+[lints]
+workspace = true

crates/macro/src/lib.rs

@@ -13,7 +13,7 @@ struct Input {
 }
 
 impl Parse for Input {
-    fn parse(input: ParseStream) -> Result<Self> {
+    fn parse(input: ParseStream<'_>) -> Result<Self> {
         let matrix = Matrix::parse_terminated_with(input, Vector::parse_separated_nonempty)?;
         Ok(Self { matrix })
     }

crates/stride/Cargo.toml

@@ -10,3 +10,6 @@ authors.workspace = true
 edition.workspace = true
 repository.workspace = true
 license.workspace = true
+
+[lints]
+workspace = true

crates/stride/src/index.rs

@@ -138,12 +138,12 @@ unsafe impl<T, const S: usize> StrideIndex<Stride<T, S>> for usize {
 
     unsafe fn get_unchecked(self, stride: *const Stride<T, S>) -> *const Self::Output {
         let i = self.unstride::<S>();
-        unsafe { (*stride).data.get_unchecked(i) }
+        unsafe { (&*stride).data.get_unchecked(i) }
     }
 
     unsafe fn get_unchecked_mut(self, stride: *mut Stride<T, S>) -> *mut Self::Output {
         let i = self.unstride::<S>();
-        unsafe { (*stride).data.get_unchecked_mut(i) }
+        unsafe { (&mut *stride).data.get_unchecked_mut(i) }
     }
 
     #[track_caller]
@@ -176,13 +176,13 @@ macro_rules! impl_stride_index {
 
             unsafe fn get_unchecked(self, stride: *const Stride<T, S>) -> *const Self::Output {
                 let i = self.unstride::<S>();
-                let slice = unsafe { (*stride).data.get_unchecked(i) };
+                let slice = unsafe { (&*stride).data.get_unchecked(i) };
                 Stride::new(slice)
             }
 
             unsafe fn get_unchecked_mut(self, stride: *mut Stride<T, S>) -> *mut Self::Output {
                 let i = self.unstride::<S>();
-                let slice = unsafe { (*stride).data.get_unchecked_mut(i) };
+                let slice = unsafe { (&mut *stride).data.get_unchecked_mut(i) };
                 Stride::new_mut(slice)
             }
 

crates/stride/src/lib.rs

@@ -294,7 +294,7 @@ impl<T, const S: usize> Stride<T, S> {
     /// assert_eq!(iterator.next(), Some(&5));
     /// assert_eq!(iterator.next(), None);
     /// ```
-    pub fn iter(&self) -> Iter<T, S> {
+    pub fn iter(&self) -> Iter<'_, T, S> {
         Iter::new(self)
     }
 
@@ -312,7 +312,7 @@ impl<T, const S: usize> Stride<T, S> {
     /// }
     /// assert_eq!(slice, &[2, 1, 4, 2, 6, 3]);
     /// ```
-    pub fn iter_mut(&mut self) -> IterMut<T, S> {
+    pub fn iter_mut(&mut self) -> IterMut<'_, T, S> {
         IterMut::new(self)
     }
 }

crates/stride/tests/lib.rs

@@ -6,13 +6,13 @@ use stride::Stride;
 #[test]
 fn stride_debug() {
     let stride = Stride::<_, 1>::new(&[1, 2, 3, 4, 5]);
-    assert_eq!(format!("{:?}", stride), "[1, 2, 3, 4, 5]");
+    assert_eq!(format!("{stride:?}"), "[1, 2, 3, 4, 5]");
 
     let stride = Stride::<_, 2>::new(&[1, 2, 3, 4, 5]);
-    assert_eq!(format!("{:?}", stride), "[1, 3, 5]");
+    assert_eq!(format!("{stride:?}"), "[1, 3, 5]");
 
     let stride = Stride::<_, 3>::new(&[1, 2, 3, 4, 5]);
-    assert_eq!(format!("{:?}", stride), "[1, 4]");
+    assert_eq!(format!("{stride:?}"), "[1, 4]");
 }
 
 #[test]

src/lib.rs

@@ -82,16 +82,16 @@
 //! Three types of element access are available.
 //!
 //! - `usize` indexing selects the nth element in the matrix as viewed in
-//!    column-major order.
-//!    ```
-//!    # use vectrix::*;
-//!    #
-//!    let m = matrix![
-//!        1, 2, 3;
-//!        4, 5, 6;
-//!    ];
-//!    assert_eq!(m[1], 4);
-//!    ```
+//!   column-major order.
+//!   ```
+//!   # use vectrix::*;
+//!   #
+//!   let m = matrix![
+//!       1, 2, 3;
+//!       4, 5, 6;
+//!   ];
+//!   assert_eq!(m[1], 4);
+//!   ```
 //!
 //! - `(usize, usize)` indexing selects the element at a particular row and
 //!   column position.
@@ -278,7 +278,6 @@
 //! ```
 
 #![no_std]
-#![warn(unsafe_op_in_unsafe_fn)]
 
 #[cfg(feature = "std")]
 extern crate std;

tests/iter.rs

@@ -3,11 +3,11 @@ use vectrix::{matrix, Matrix};
 #[test]
 fn into_iter_debug() {
     let mut into_iter = matrix![1, 3; 3, 7].into_iter();
-    assert_eq!(format!("{:?}", into_iter), "IntoIter([1, 3, 3, 7])");
+    assert_eq!(format!("{into_iter:?}"), "IntoIter([1, 3, 3, 7])");
     into_iter.next();
-    assert_eq!(format!("{:?}", into_iter), "IntoIter([3, 3, 7])");
+    assert_eq!(format!("{into_iter:?}"), "IntoIter([3, 3, 7])");
     into_iter.next_back();
-    assert_eq!(format!("{:?}", into_iter), "IntoIter([3, 3])");
+    assert_eq!(format!("{into_iter:?}"), "IntoIter([3, 3])");
 }
 
 #[test]