Skip to content

Commit 6047e3c

Browse files
authored
Merge pull request #28 from roubachof/remove-net8
2 parents 9eb9eed + 9fca92b commit 6047e3c

File tree

2 files changed

+13
-35
lines changed

2 files changed

+13
-35
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,21 @@ This proxy provides enough API for [Xamarin.Forms.Nuke][xformsnuke] to function.
55

66
## Installation
77

8-
New! There is now a .net 6 version of the proxy targeting `ios` and `mac catalyst`.
8+
ImageCaching.Nuke supports .NET 9 for `ios` and `maccatalyst` targets
99

10-
### .Net 6 ios and macos
10+
### .NET 9 iOS and macOS
1111

1212
Nuget:
1313

1414
> Install-Package ImageCaching.Nuke
1515
16-
### Xamarin.Forms
16+
### MAUI UI framework
1717

1818
NuGet:
1919

20-
> Install-Package Xamarin.Nuke
20+
> Install-Package https://www.nuget.org/packages/Sharpnado.Maui.Nuke
2121
22-
## Setting up locally
22+
## Building locally
2323

2424
Make sure to install carthage first. This can be done through Homebrew:
2525

src/ImageCaching.Nuke/ImageCaching.Nuke.csproj

Lines changed: 8 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<TargetFrameworks>net8.0-ios;net8.0-maccatalyst;net9.0-ios;net9.0-maccatalyst</TargetFrameworks>
3+
<TargetFrameworks>net9.0-ios;net9.0-maccatalyst</TargetFrameworks>
44
<IsBindingProject>true</IsBindingProject>
55
<NoBindingEmbedding>true</NoBindingEmbedding>
66
<RootNamespace>ImageCaching.Nuke</RootNamespace>
7-
<SupportedOSPlatformVersion Condition="'$(TargetFramework)' == 'net8.0-ios'">14.0</SupportedOSPlatformVersion>
8-
<SupportedOSPlatformVersion Condition="'$(TargetFramework)' == 'net8.0-maccatalyst'">14.0</SupportedOSPlatformVersion>
97
<SupportedOSPlatformVersion Condition="'$(TargetFramework)' == 'net9.0-ios'">14.0</SupportedOSPlatformVersion>
108
<SupportedOSPlatformVersion Condition="'$(TargetFramework)' == 'net9.0-maccatalyst'">14.0</SupportedOSPlatformVersion>
119
<BindingPlatform>$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)'))</BindingPlatform>
@@ -19,47 +17,27 @@
1917
<Owners>roubachof,cheesebaron</Owners>
2018
<PackageTags>xamarin.ios ios nuke image caching glidex</PackageTags>
2119
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
20+
</PropertyGroup>
21+
22+
<PropertyGroup Condition=" '$(TF_BUILD)' == 'true' OR '$(GITHUB_ACTIONS)' == 'true' ">
23+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
24+
<Deterministic>true</Deterministic>
2225

2326
<PublishRepositoryUrl>true</PublishRepositoryUrl>
2427
<RepositoryUrl>https://github.com/roubachof/NukeProxy</RepositoryUrl>
2528
<RepositoryType>git</RepositoryType>
26-
</PropertyGroup>
2729

28-
<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
29-
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
30-
<IncludeSymbols>true</IncludeSymbols>
31-
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
3230
<EmbedUntrackedSources>true</EmbedUntrackedSources>
31+
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
3332

34-
<DesignTimeBuild>false</DesignTimeBuild>
35-
<DebugType>full</DebugType>
36-
<DebugSymbols>true</DebugSymbols>
37-
38-
<GeneratePackageOnBuild Condition=" '$(IsTestProject)' != 'true'">true</GeneratePackageOnBuild>
33+
<DebugType>embedded</DebugType>
3934
</PropertyGroup>
4035

4136
<ItemGroup>
4237
<None Include="..\..\LICENSE" Pack="true" PackagePath="" />
4338
<None Include="..\..\nuke_small.png" Pack="true" PackagePath="" />
4439
</ItemGroup>
4540

46-
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
47-
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
48-
<Deterministic>true</Deterministic>
49-
</PropertyGroup>
50-
51-
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
52-
<MtouchLink>SdkOnly</MtouchLink>
53-
<MtouchHttpClientHandler>HttpClientHandler</MtouchHttpClientHandler>
54-
</PropertyGroup>
55-
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
56-
<MtouchLink>SdkOnly</MtouchLink>
57-
<MtouchHttpClientHandler>HttpClientHandler</MtouchHttpClientHandler>
58-
</PropertyGroup>
59-
<ItemGroup>
60-
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
61-
</ItemGroup>
62-
6341
<ItemGroup>
6442
<ObjcBindingApiDefinition Include="ApiDefinition.cs" />
6543
<ObjcBindingCoreSource Include="Structs.cs" />

0 commit comments

Comments
 (0)