Skip to content

Commit 7ab3336

Browse files
committed
Update readme and fix UWP package for older version of W10
1 parent 20321c4 commit 7ab3336

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ On `iOS` add this line after `Xamarin.Forms.Forms.Init()` and before `LoadApplic
2121

2222
`Sharpnado.Shades.iOS.iOSShadowsRenderer.Initialize();`
2323

24+
In `UWP`, you must register the renderers assembly like this, before `Xamarin.Forms.Forms.Init()`:
25+
26+
`var rendererAssemblies = new[] { typeof(UWPShadowsRenderer).GetTypeInfo().Assembly }; `
2427

2528
On `Tizen` add this line after `Xamarin.Forms.Forms.Init()` and before `LoadApplication(new App())`.
2629

Shadows/Shadows.UWP/UWPShadowsController.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ private void ShadowSourceSizeChanged(object sender, SizeChangedEventArgs e)
159159

160160
InternalLogger.Debug(
161161
LogTag,
162-
$"shadowSource: {{ ActualOffset: {_shadowSource.ActualOffset}, ActualSize: {_shadowSource.ActualSize}, Margin: {_shadowSource.Margin} }}");
162+
() => $"shadowSource: {{ Offset: {offset}, Size: {width}x{height}, Margin: {_shadowSource.Margin} }}");
163163

164164
for (int i = 0; i < _shadesSource.Count(); i++)
165165
{
@@ -168,7 +168,8 @@ private void ShadowSourceSizeChanged(object sender, SizeChangedEventArgs e)
168168

169169
InternalLogger.Debug(
170170
LogTag,
171-
$"shadowHost: {{ ActualOffset: {shadowHost.ActualOffset}, ActualSize: {shadowHost.ActualSize}, Margin: {shadowHost.Margin} }}");
171+
() => $"shadowHost: {{ Size: {shadowHost.ActualWidth}x{shadowHost.ActualHeight}, Margin: {shadowHost.Margin} }}");
172+
172173
Canvas.SetLeft(shadowHost, offset.X + SafeMargin);
173174
Canvas.SetTop(shadowHost, offset.Y + SafeMargin);
174175

Sharpnado.Shadows.nuspec

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ Mandatory initialization on iOS:
3232
Xamarin.Forms.Forms.Init();
3333
Sharpnado.Shades.iOS.iOSShadowsRenderer.Initialize();
3434

35+
Mandatory initialization on UWP:
36+
37+
var rendererAssemblies = new[] { typeof(UWPShadowsRenderer).GetTypeInfo().Assembly };
38+
Xamarin.Forms.Forms.Init(e, rendererAssemblies);
39+
3540
Mandatory initialization on Tizen:
3641

3742
Xamarin.Forms.Forms.Init();

0 commit comments

Comments
 (0)