Merge branch 'issue-3'

roubachof · roubachof · commit e140aba5481d · 2020-06-18T12:18:45.000+02:00
diff --git a/Shadows/AssemblyInfo.targets b/Shadows/AssemblyInfo.targets
@@ -3,7 +3,7 @@
 
   <PropertyGroup>
     <Copyright>Copyright © Sharpnado 2020</Copyright>
-    <Version>1.0.0</Version>
+    <Version>1.0.1</Version>
     <Company>Sharpnado</Company>
     <Product>Shadows</Product>
     <Description>Add as many custom shadows as you like to any Xamarin.Forms view (Android, iOS, UWP). Set Color, Opacity, Blur, and Offset for each shadow.</Description>
diff --git a/Shadows/Shadows.Droid/AndroidShadowsRenderer.cs b/Shadows/Shadows.Droid/AndroidShadowsRenderer.cs
@@ -30,6 +30,17 @@ protected override void OnElementChanged(ElementChangedEventArgs<Shadows> e)
             }
         }
 
+        protected override void Dispose(bool disposing)
+        {
+            base.Dispose(disposing);
+
+            InternalLogger.Debug("Renderer", $"Disposed( disposing: {disposing} )");
+            if (disposing)
+            {
+                _shadowView?.Dispose();
+            }
+        }
+
         protected override void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)
         {
             base.OnElementPropertyChanged(sender, e);
diff --git a/Shadows/Shadows.Droid/AssemblyInfo.cs b/Shadows/Shadows.Droid/AssemblyInfo.cs
@@ -14,7 +14,7 @@
     "WP). Set Color, Opacity, Blur, and Offset for each shadow.")]
 [assembly: System.Reflection.AssemblyProduct("Shadows")]
 [assembly: System.Reflection.AssemblyCopyright("Copyright © Sharpnado 2020")]
-[assembly: System.Reflection.AssemblyVersion("1.0.0")]
-[assembly: System.Reflection.AssemblyFileVersion("1.0.0")]
+[assembly: System.Reflection.AssemblyVersion("1.0.1")]
+[assembly: System.Reflection.AssemblyFileVersion("1.0.1")]
 
 
diff --git a/Shadows/Shadows.UWP/AssemblyInfo.cs b/Shadows/Shadows.UWP/AssemblyInfo.cs
@@ -1,10 +1,10 @@
 ﻿//------------------------------------------------------------------------------
 // <auto-generated>
-//     This code was generated by a tool.
-//     Runtime Version:4.0.30319.42000
+//     Ce code a été généré par un outil.
+//     Version du runtime :4.0.30319.42000
 //
-//     Changes to this file may cause incorrect behavior and will be lost if
-//     the code is regenerated.
+//     Les modifications apportées à ce fichier peuvent provoquer un comportement incorrect et seront perdues si
+//     le code est régénéré.
 // </auto-generated>
 //------------------------------------------------------------------------------
 
@@ -14,7 +14,7 @@
     "WP). Set Color, Opacity, Blur, and Offset for each shadow.")]
 [assembly: System.Reflection.AssemblyProduct("Shadows")]
 [assembly: System.Reflection.AssemblyCopyright("Copyright © Sharpnado 2020")]
-[assembly: System.Reflection.AssemblyVersion("1.0.0")]
-[assembly: System.Reflection.AssemblyFileVersion("1.0.0")]
+[assembly: System.Reflection.AssemblyVersion("1.0.1")]
+[assembly: System.Reflection.AssemblyFileVersion("1.0.1")]
 
 
diff --git a/Shadows/Shadows.iOS/AssemblyInfo.cs b/Shadows/Shadows.iOS/AssemblyInfo.cs
@@ -1,10 +1,10 @@
 ﻿//------------------------------------------------------------------------------
 // <auto-generated>
-//     This code was generated by a tool.
-//     Runtime Version:4.0.30319.42000
+//     Ce code a été généré par un outil.
+//     Version du runtime :4.0.30319.42000
 //
-//     Changes to this file may cause incorrect behavior and will be lost if
-//     the code is regenerated.
+//     Les modifications apportées à ce fichier peuvent provoquer un comportement incorrect et seront perdues si
+//     le code est régénéré.
 // </auto-generated>
 //------------------------------------------------------------------------------
 
@@ -14,7 +14,7 @@
     "WP). Set Color, Opacity, Blur, and Offset for each shadow.")]
 [assembly: System.Reflection.AssemblyProduct("Shadows")]
 [assembly: System.Reflection.AssemblyCopyright("Copyright © Sharpnado 2020")]
-[assembly: System.Reflection.AssemblyVersion("1.0.0")]
-[assembly: System.Reflection.AssemblyFileVersion("1.0.0")]
+[assembly: System.Reflection.AssemblyVersion("1.0.1")]
+[assembly: System.Reflection.AssemblyFileVersion("1.0.1")]
 
 
diff --git a/Shadows/Shadows/AssemblyInfo.cs b/Shadows/Shadows/AssemblyInfo.cs
@@ -14,7 +14,7 @@
     "WP). Set Color, Opacity, Blur, and Offset for each shadow.")]
 [assembly: System.Reflection.AssemblyProduct("Shadows")]
 [assembly: System.Reflection.AssemblyCopyright("Copyright © Sharpnado 2020")]
-[assembly: System.Reflection.AssemblyVersion("1.0.0")]
-[assembly: System.Reflection.AssemblyFileVersion("1.0.0")]
+[assembly: System.Reflection.AssemblyVersion("1.0.1")]
+[assembly: System.Reflection.AssemblyFileVersion("1.0.1")]
 
 
diff --git a/Sharpnado.Shadows.nuspec b/Sharpnado.Shadows.nuspec
@@ -15,7 +15,7 @@
       <repository type="git" branch="master" url="https://github.com/roubachof/Sharpnado.Shadows" />
       <summary>Add as many custom shadows as you like to any Xamarin.Forms view (Android, iOS, UWP). You can set Color, Opacity, Blur, Offset and CornerRadius. Easily achieve neumorphism.</summary>
       <tags>xamarin.forms android ios uwp netstandard shadow blur color shadows neumorphism</tags>
-      <releaseNotes>First release.</releaseNotes>
+      <releaseNotes>Fix a memory leak on Android.</releaseNotes>
       <description>
 Add as many custom shadows as you like to any Xamarin.Forms view (Android, iOS, UWP). 
 

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,17 @@ protected override void OnElementChanged(ElementChangedEventArgs<Shadows> e)`
`30`	`30`	`}`
`31`	`31`	`}`
`32`	`32`
	`33`	`+ protected override void Dispose(bool disposing)`
	`34`	`+ {`
	`35`	`+ base.Dispose(disposing);`
	`36`	`+`
	`37`	`+ InternalLogger.Debug("Renderer", $"Disposed( disposing: {disposing} )");`
	`38`	`+ if (disposing)`
	`39`	`+ {`
	`40`	`+ _shadowView?.Dispose();`
	`41`	`+ }`
	`42`	`+ }`
	`43`	`+`
`33`	`44`	`protected override void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)`
`34`	`45`	`{`
`35`	`46`	`base.OnElementPropertyChanged(sender, e);`