Added testing for and modified clean_dict

Author: tommycbird

route4me/advanced_constraint.py

@@ -20,24 +20,7 @@ def __init__(self):
             "lat": None,
             "lng": None,
         }
-        self.location_sequence_pattern = [
-            "",
-            {
-                "alias": None,
-                "address": None,
-                "lat": None,
-                "lng": None,
-            }
-        ]
-        self.location_sequence_pattern = [
-            "",
-            {
-                "alias": None,
-                "address": None,
-                "lat": None,
-                "lng": None,
-            }
-        ]
+        self.location_sequence_pattern = []
         self.group = None
 
     def to_dict(self):

route4me/utils.py

@@ -38,16 +38,16 @@ def clean_dict(data):
         cleaned_list = []
         for i in data:
             cleaned_item = clean_dict(i)
-            # Append non-None items
-            if cleaned_item not in [None, ""]:
+            # Append non-None items except empty strings
+            if cleaned_item or cleaned_item == "":
                 cleaned_list.append(cleaned_item)
         return cleaned_list if cleaned_list else None
     elif isinstance(data, dict):
         cleaned_dict = {}
         for k, v in data.items():
             cleaned_v = clean_dict(v)
             # Append non-None key-value pairs
-            if cleaned_v not in [None, ""]:
+            if cleaned_v:
                 cleaned_dict[k] = cleaned_v
         return cleaned_dict if cleaned_dict else None
     else:

tests/test_utils.py

@@ -2,6 +2,7 @@
 import unittest
 
 from route4me.utils import json2obj
+from route4me.utils import clean_dict
 from tests.base import Route4MeAPITestSuite
 
 
@@ -15,6 +16,31 @@ def test_json2obj(self):
         json_obj = json2obj(json_data)
         self.assertTrue(hasattr(json_obj, 'variable1'))
 
+    def test_clean_dict(self):
+        # None and "" values
+        input_dict = {"key1": "value1", "key2": None, "key3": "", "key4": ["", None, "value4"]}
+        cleaned_dict = clean_dict(input_dict)
+        expected_dict = {"key1": "value1", "key4": ["", "value4"]}
+        self.assertEqual(cleaned_dict, expected_dict)
+
+        # empty dict and list values
+        input_dict = {"key1": "value1", "key2": {}, "key3": []}
+        cleaned_dict = clean_dict(input_dict)
+        expected_dict = {"key1": "value1"}
+        self.assertEqual(cleaned_dict, expected_dict)
+
+        # None and "" values
+        input_list = ["value1", None, "", ["", None, "value2"]]
+        cleaned_list = clean_dict(input_list)
+        expected_list = ["value1", "", ["", "value2"]]
+        self.assertEqual(cleaned_list, expected_list)
+
+        # empty dict and list values
+        input_list = ["value1", {}, []]
+        cleaned_list = clean_dict(input_list)
+        expected_list = ["value1"]
+        self.assertEqual(cleaned_list, expected_list)
+
 
 if __name__ == '__main__':
     unittest.main()