Skip to content

Cleanup - Remove some old go.mod|sum files, and fix an import path.#75

Merged
morrowc merged 2 commits intomainfrom
cleanup
May 4, 2025
Merged

Cleanup - Remove some old go.mod|sum files, and fix an import path.#75
morrowc merged 2 commits intomainfrom
cleanup

Conversation

@morrowc
Copy link
Collaborator

@morrowc morrowc commented May 4, 2025

When this code moved under this project it's go.mod/sum files weren't removed.
They were likely ignored, but they are confusing, so remove them.

Additionally, when moving from old -> new location, the proto import needed
an update, which was missed in the move event.

main.go now compiles.

morrowc added 2 commits May 4, 2025 18:23
A golang project should have 1 set of go.mod/sum files, in the root of
the project.
I believe the previous home for this and move to the
RV location didn't account for the RV path element.
@morrowc morrowc requested a review from hanskuhn May 4, 2025 22:43
@morrowc
Copy link
Collaborator Author

morrowc commented May 4, 2025

Ideally now the parts build properly AND cron/app work in appengine.
A tad hard to debug/diagnose appengine is :(

Copy link
Member

@hanskuhn hanskuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidy tidy. 🧹

OK to merge!

@morrowc morrowc merged commit 5a45e58 into main May 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants