Merge pull request #9 from ericdong79/dev/fix-possible-source-undefined

rowanwins · web-flow · commit 8f826a4de1f2 · 2023-06-13T21:27:19.000+10:00
fix: error if source is undefined
diff --git a/src/main.js b/src/main.js
@@ -302,7 +302,13 @@ export default class FeatureService {
   }
 
   _updateFcOnMap(fc) {
-    this._map.getSource(this.sourceId).setData(fc)
+    const source = this._map.getSource(this.sourceId);
+    if(source){
+      source.setData(fc)
+    }
+    else{
+      console.warn(`Cannot find source with id: ${this.sourceId}`)
+    }
   }
 
   _doesTileOverlapBbox(tile, bbox) {

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,13 @@ export default class FeatureService {`
`302`	`302`	`}`
`303`	`303`
`304`	`304`	`_updateFcOnMap(fc) {`
`305`		`- this._map.getSource(this.sourceId).setData(fc)`
	`305`	`+ const source = this._map.getSource(this.sourceId);`
	`306`	`+ if(source){`
	`307`	`+ source.setData(fc)`
	`308`	`+ }`
	`309`	`+ else{`
	`310`	+ console.warn(`Cannot find source with id: ${this.sourceId}`)
	`311`	`+ }`
`306`	`312`	`}`
`307`	`313`
`308`	`314`	`_doesTileOverlapBbox(tile, bbox) {`